Skip to content

Fix mono debugger thread block when wait for attach #62175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdageek merged 8 commits into from
Dec 2, 2021
Merged

Fix mono debugger thread block when wait for attach #62175

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ceac159
mono_runtime_delegate_invoke wrapper with MONO_ENTER_GC_UNSAFE/MONO_E…
srxqds Nov 24, 2021
a56b0cf
Update object.c
srxqds Nov 24, 2021
3de69c4
Merge branch 'dotnet:main' into main
srxqds Nov 24, 2021
5fcf23a
Merge branch 'dotnet:main' into main
srxqds Nov 29, 2021
2be859e
set debugger thread flags to MONO_THREAD_INFO_FLAGS_NO_GC | MONO_THRE…
srxqds Nov 30, 2021
60b19dc
wait_for_attach change to gc safe mode
srxqds Nov 30, 2021
07117d6
remove empty indent
srxqds Nov 30, 2021
b9d6083
change MONO_REQ_GC_SAFE_MODE to MONO_REQ_GC_UNSAFE_MODE
srxqds Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wait_for_attach change to gc safe mode
  • Loading branch information
@srxqds
srxqds authored Nov 30, 2021
commit 60b19dc2cb5b0a5c6d6396ac2341640c271b9232
5 changes: 3 additions & 2 deletions src/mono/mono/component/debugger-agent.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10031,8 +10031,10 @@ wait_for_attach (void)
}

/* Block and wait for client connection */
MONO_ENTER_GC_SAFE;
conn_fd = socket_transport_accept (listen_fd);

MONO_EXIT_GC_SAFE;

PRINT_DEBUG_MSG (1, "Accepted connection on %d\n", conn_fd);
if (conn_fd == -1) {
PRINT_DEBUG_MSG (1, "[dbg] Bad client connection\n");
Expand Down Expand Up @@ -10140,7 +10142,6 @@ debugger_thread (void *arg)

internal->state |= ThreadState_Background;
internal->flags |= MONO_THREAD_FLAG_DONT_MANAGE;
mono_thread_info_set_flags(MONO_THREAD_INFO_FLAGS_NO_GC | MONO_THREAD_INFO_FLAGS_NO_SAMPLE);

if (agent_config.defer) {
if (!wait_for_attach ()) {
Expand Down