Skip to content

Add almalinux support #62184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eabdullin1 wants to merge 3 commits into from
Closed

Add almalinux support #62184

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1a7097
Added almalinux support
Nov 23, 2021
df1b7d5
Merge branch 'main' into main
eabdullin1 Dec 1, 2021
62b760f
Update eng/native/init-distro-rid.sh
eabdullin1 Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update eng/native/init-distro-rid.sh 
This way is better

Co-authored-by: Adeel Mujahid <[email protected]>
  • Loading branch information
@eabdullin1 @am11
eabdullin1 and am11 authored Dec 2, 2021
commit 62b760f485dd5dba1961fbd2ea355088e611fbc7
4 changes: 2 additions & 2 deletions eng/native/init-distro-rid.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ initNonPortableDistroRid()
# We have forced __PortableBuild=0. This is because -portablebuld
# has been passed as false.
if (( isPortable == 0 )); then
if [[ "${ID}" == "rhel" || "${ID}" == "rocky" || "${ID}" == "almalinux" ]]; then
# remove the last version digit
# for RHEL and its derivatives, remove the last version digit (if present)
if [[ "${ID}" == "rhel" || "${ID_LIKE}" =~ .*rhel.* ]]; then
Copy link
Member

@eerhardt eerhardt Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this also affect centos and fedora?

Copy link
Member

@am11 am11 Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition matches centos but not fedora.
After that value on centos is not affected by the line below, so it is only for distros which we have version / release policy like RHEL and are derivatives of that.

Copy link
Member

@am11 am11 Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, these PRs are not really needed, unless the distro really wants to create a "non-portable" release of .NET and provide some distro-specific packages.

https://dotnet.microsoft.com/download/dotnet/thank-you/sdk-6.0.100-linux-x64-binaries works for any glibc-based linux distro..

non-portable is only used by source builds for a long time now, elsewhere we all use portable binaries, so these PRs are less meaningful.

VERSION_ID="${VERSION_ID%.*}"
fi

Expand Down