Skip to content

Conversation

@vargaz
Copy link
Contributor

@vargaz vargaz commented Nov 30, 2021

…ze it away causing an assert inside 'opt'.

@lateralusX
Copy link
Member

Validate that this works on a test assembly currently hitting this issue.

@akoeplinger
Copy link
Member

A bunch of the wasm tests fail with something that looks related:

[wasm test] [03:27:17] info: ./dotnet.js:5625: SyntaxError: Unexpected token '.'
[wasm test] [03:27:17] info: var _gc.safepoint_poll = Module["_gc.safepoint_poll"] = function() {
[wasm test] [03:27:17] info:        ^
[wasm test] [03:27:17] info: SyntaxError: Unexpected token '.'
[wasm test] [03:27:17] info:     at loadScript (main.js:383:24)
[wasm test] [03:27:17] info:     at loadDotnet (main.js:391:12)
[wasm test] [03:27:17] info:     at main.js:394:1
[wasm test] [03:27:17] info: 
[wasm test] [03:27:17] info: Process v8 exited with 0

@akoeplinger akoeplinger merged commit 4f244b3 into dotnet:main Dec 1, 2021
@akoeplinger
Copy link
Member

do we need to backport this?

@vargaz vargaz deleted the llvm-used branch December 1, 2021 22:32
@vargaz
Copy link
Contributor Author

vargaz commented Dec 1, 2021

No, it only happens on some newer windows platforms.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants