Skip to content

[release/6.0] fix issue where HTTP2 connection could be scavenged but not disposed #62236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
safern merged 1 commit into from
Jan 3, 2022
Merged

[release/6.0] fix issue where HTTP2 connection could be scavenged but not disposed #62236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1999,7 +1999,8 @@ static int ScavengeConnectionList<T>(List<T> list, ref List<HttpConnectionBase>?
if (freeIndex < list.Count)
{
// We know the connection at freeIndex is unusable, so dispose of it.
toDispose ??= new List<HttpConnectionBase> { list[freeIndex] };
toDispose ??= new List<HttpConnectionBase>();
toDispose.Add(list[freeIndex]);

// Find the first item after the one to be removed that should be kept.
int current = freeIndex + 1;
Expand Down