Skip to content

[wasm][debugger] View object attributes - DebugType=full #62278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaystg merged 8 commits into from
Dec 8, 2021
Merged

[wasm][debugger] View object attributes - DebugType=full #62278

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8f51971
Fix view variable values from an assembly with debugType = full
thaystg Dec 2, 2021
ef5aaf9
Addressing @ilonatommy comment.
thaystg Dec 2, 2021
efc93e0
Adding the csproj for the new test.
thaystg Dec 3, 2021
01630c0
Adressing @radical comments.
thaystg Dec 3, 2021
f788f9f
Apply suggestions from code review
thaystg Dec 6, 2021
083368a
Removing method duplicated.
thaystg Dec 6, 2021
0aea3de
Calling Runtime.consoleAPICalled.
thaystg Dec 6, 2021
1a30555
addressing @radical comment.
thaystg Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Addressing @ilonatommy comment.
  • Loading branch information
@thaystg
thaystg committed Dec 2, 2021
commit ef5aaf94beffb31d170e39258adfcd0f13f89837
2 changes: 1 addition & 1 deletion src/mono/wasm/debugger/DebuggerTestSuite/Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@ public async Task InspectLocalsUsingClassFromLibraryUsingDebugTypeFull()

await EvaluateAndCheck(
"window.setTimeout(function() {" + expression + "; }, 1);",
"dotnet://debugger-test.dll/debugger-test.cs", 861, 8,
"dotnet://debugger-test.dll/debugger-test.cs", 860, 8,
"CallToEvaluateLocal",
wait_for_event_fn: async (pause_location) =>
{
Expand Down
1 change: 0 additions & 1 deletion src/mono/wasm/debugger/tests/debugger-test/debugger-test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,6 @@ public static void CallToEvaluateLocal(string asm_base64, string pdb_base64)
var myType = asm.GetType("DebuggerTests.ClassToInspectWithDebugTypeFull");
var myMethod = myType.GetConstructor(new Type[] { });
var a = myMethod.Invoke(new object[]{});
Console.WriteLine(a);
System.Diagnostics.Debugger.Break();
}
}