[release/6.0] Cache LastAccessed during MemoryCache compaction #62286
Conversation
* Cache LastAccessed during MemoryCache compaction During cache compaction, we are sorting entries based on their LastAccessed time. However, since the cache entries can still be used concurrently on other threads, the LastAccessed time may be updated in the middle of sorting the entries. This leads to exceptions in a background thread, crashing the process. The fix is to cache the LastAccessed time outside of the entry when we are adding it to the list. This will ensure the time is stable during the compaction process. Fix dotnet#61032
1. Remove the dependency on ValueTuple and use a custom struct instead. 2. Add servicing package changes. 3. In the tests, move the DisableParallelization collection declaration in the test project, since it is only in "Common" in main.
eerhardt
added
Servicing-consider
|
Tagging subscribers to this area: @dotnet/area-extensions-caching Issue DetailsBackport of #61187 to release/6.0 Customer ImpactThere is a race condition in MemoryCache compaction that can cause apps to crash (since the compaction happens on a background thread, and an unhandled exception can be thrown). This can seemingly crash their process randomly. TestingAdded a new multi-threaded test that tests the scenario. RiskLow Risk. The change is to snapshot the Note for reviewersI have 2 commits. The first commit is what was merged into Fix #61032
|
Pilchie
added
Servicing-approved
| { | ||
| case CacheItemPriority.Low: | ||
| lowPriEntries.Add(entry); | ||
| lowPriEntries.Add(new CompactPriorityEntry(entry, entry.LastAccessed)); |
There was a problem hiding this comment.
I assume there will not be any boxing operation that causes additional allocations. right?
There was a problem hiding this comment.
Correct. We are using a List<CompactPriorityEntry>, so no boxing will occur. The small structs will just be copied in and out of the list. This is the same with the 7.0+ implementation, but there we are using ValueTuple instead of a custom struct.
safern
added
the
NO-MERGE
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @eerhardt !
| <EnableDefaultItems>true</EnableDefaultItems> | ||
| <PackageDescription>In-memory cache implementation of Microsoft.Extensions.Caching.Memory.IMemoryCache.</PackageDescription> | ||
| <GeneratePackageOnBuild>true</GeneratePackageOnBuild> | ||
| <ServicingVersion>1</ServicingVersion> |
There was a problem hiding this comment.
@safern - this is all I need to do to service this package, correct?
safern
left a comment
safern
left a comment
There was a problem hiding this comment.
Packaging updates look good to me.
safern
removed
the
NO-MERGE
ghost
locked as resolved and limited conversation to collaborators
5 participants
Backport of #61187 to release/6.0
Customer Impact
There is a race condition in MemoryCache compaction that can cause apps to crash (since the compaction happens on a background thread, and an unhandled exception can be thrown). This can seemingly crash their process randomly.
Testing
Added a new multi-threaded test that tests the scenario.
Risk
Low Risk. The change is to snapshot the
LastAccessedvalue, so even if it is updated during compaction, it won't cause an issue.Note for reviewers
I have 2 commits. The first commit is what was merged into
mainwith #61187. The second commit are the changes necessary for servicing.Fix #61032