Fixes #62167. WriteAsync may truncate data if called after .Advance(int) #62306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts if called after an .Advance(int)
ghost
added
area-System.IO.Pipelines
community-contribution
Member
|
While this is an unusual writing pattern, it is valid. You can get corrupted data without this fix. We should service this. |
Member
|
thanks @Kuinox ! |
Contributor
Author
I use this pattern to write an user provided buffer. |
BrennanConroy
approved these changes
Dec 3, 2021
Member
|
Thanks a lot @Kuinox! |
Member
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1536724263 |
Member
|
/backport to release/5.0 |
Contributor
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/1536755422 |
Contributor
Author
|
Thanks everyone ! |
Member
|
Thank you! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62167.
It took me way too much time to pinpoint where this issue came from ^^'.