Skip to content

Delete old code generation approach from RegexCompiler / source generator #62318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 4 commits into from
Dec 3, 2021
Merged

Delete old code generation approach from RegexCompiler / source generator #62318

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40da844
Delete old code generation approach from RegexCompiler / source gener…
stephentoub Dec 2, 2021
7e5c941
Make the addition of more declarations a bit more robust
stephentoub Dec 2, 2021
350c756
Reduce backtracking code gen when nodes are atomic
stephentoub Dec 3, 2021
dcffd8d
Fix tests on mono interpreter
stephentoub Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix tests on mono interpreter
  • Loading branch information
@stephentoub
stephentoub committed Dec 3, 2021
commit dcffd8de0fa5d1c8878bd7c43485cff546300f78
6 changes: 5 additions & 1 deletion src/libraries/System.Text.RegularExpressions/tests/Regex.MultipleMatches.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System.Threading.Tasks;
using Xunit;
using System.Linq;
using System.Runtime.CompilerServices;

namespace System.Text.RegularExpressions.Tests
{
Expand Down Expand Up @@ -327,7 +328,9 @@ public static IEnumerable<object[]> Matches_TestData()
}
}

if (engine != RegexEngine.Interpreter && !PlatformDetection.IsNetFramework)
#if !NETFRAMEWORK // these tests currently fail on .NET Framework, and we need to check IsDynamicCodeCompiled but that doesn't exist on .NET Framework
if (engine != RegexEngine.Interpreter && // these tests currently fail with RegexInterpreter
RuntimeFeature.IsDynamicCodeCompiled) // if dynamic code isn't compiled, RegexOptions.Compiled falls back to the interpreter, for which these tests currently fail
{
// Fails on interpreter and .NET Framework: [ActiveIssue("https://github.com/dotnet/runtime/issues/62094")]
yield return new object[]
Expand Down Expand Up @@ -360,6 +363,7 @@ public static IEnumerable<object[]> Matches_TestData()
};
}
}
#endif
}
}

Expand Down