Fix re-initialization of hash objects on CNG. #62397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In .NET 6, we added "real" support for Initialize on hash objects. However, the Reset call would create a new hash object without the CNG "resuable" flag. This led to the HashProvider's "_reusable" field and the actual reusability of the hash instance to disagree.
ghost
added
area-System.Security
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones, @krwq Issue DetailsIn .NET 6, we added "real" support for Initialize on hash objects. However, the Reset call would create a new hash object without the CNG "resuable" flag. This led to the HashProvider's "_reusable" field and Contributes to #61417
|
Member
Author
|
@bartonjs @GrabYourPitchforks this might be a reasonable candidate to backport to |
Member
Author
|
For sake of documenting, the test failure before the fix is applied: Failed System.Security.Cryptography.Tests.Sha1ManagedTests.Initialize_DoubleInitialize_Works [13 ms]
Error Message:
Internal.Cryptography.CryptoThrowHelper+WindowsCryptographicException : Unknown error (0xc1000008)
Stack Trace:
at Internal.Cryptography.HashProviderCng.AppendHashData(ReadOnlySpan`1 source) in D:\code\personal\runtime\src\libraries\Common\src\Internal\Cryptography\HashProviderCng.cs:line 69
at Internal.Cryptography.HashProvider.AppendHashData(Byte[] data, Int32 offset, Int32 count) in D:\code\personal\runtime\src\libraries\Common\src\Internal\Cryptography\HashProvider.cs:line 31
at System.Security.Cryptography.SHA1Managed.HashCore(Byte[] array, Int32 ibStart, Int32 cbSize) in D:\code\personal\runtime\src\libraries\System.Security.Cryptography\src\System\Security\Cryptography\SHA1Managed.cs:line 23
at System.Security.Cryptography.HashAlgorithm.TransformFinalBlock(Byte[] inputBuffer, Int32 inputOffset, Int32 inputCount) in D:\code\personal\runtime\src\libraries\System.Security.Cryptography\src\System\Security\Cryptography\HashAlgorithm.cs:line 224
at System.Security.Cryptography.Tests.HashAlgorithmTestDriver.Initialize_DoubleInitialize_Works() in D:\code\personal\runtime\src\libraries\System.Security.Cryptography\tests\HashAlgorithmTestDriver.cs:line 509
|
bartonjs
approved these changes
Dec 4, 2021
Member
|
/backport-to release/6.0 |
Member
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1539711211 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In .NET 6, we added real support for Initialize on hash objects, prior to that it was a no-op. However, the Reset call would create a new hash object without the CNG "resuable" flag. This led to the HashProvider's "_reusable" field and the actual reusability of the hash instance to disagree.
Contributes to #61417