Skip to content

[wasm] Reduce number of calls to setTimer #62433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelsavara merged 10 commits into from
Dec 10, 2021
Merged

[wasm] Reduce number of calls to setTimer #62433

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
68168ba
wip
pavelsavara Dec 8, 2021
927a027
no id
pavelsavara Dec 8, 2021
9bb2585
feedback
pavelsavara Dec 8, 2021
f693c9a
cleanup
pavelsavara Dec 8, 2021
ac3fb95
cleanup
pavelsavara Dec 8, 2021
cc45045
typo
pavelsavara Dec 8, 2021
29b37a2
switch to new xunit/xharness
pavelsavara Dec 8, 2021
26e2b49
improve test
pavelsavara Dec 8, 2021
b71b244
only on browser, make less noise
pavelsavara Dec 9, 2021
df27bdc
feedback
pavelsavara Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
switch to new xunit/xharness
  • Loading branch information
@pavelsavara
pavelsavara committed Dec 9, 2021
commit 29b37a2b368702da6153babf10bcaa66a2ffca06
16 changes: 4 additions & 12 deletions ...pServices.JavaScript/tests/System.Private.Runtime.InteropServices.JavaScript.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
<TargetFrameworks>$(NetCoreAppCurrent)-Browser</TargetFrameworks>
<TestRuntime>true</TestRuntime>
<WasmXHarnessArgs>$(WasmXHarnessArgs) --engine-arg=--expose-gc --web-server-use-cop</WasmXHarnessArgs>
<_TestAssembly>System.Private.Runtime.InteropServices.JavaScript.Tests.dll</_TestAssembly>
<OutputType>Exe</OutputType>
<Scenario>WasmTestOnBrowser</Scenario>
</PropertyGroup>
<ItemGroup>
<Compile Include="System\Runtime\InteropServices\JavaScript\JavaScriptTests.cs" />
Expand All @@ -19,21 +18,14 @@
<Compile Include="System\Runtime\InteropServices\JavaScript\HelperMarshal.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\Http\HttpRequestMessageTest.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\ParallelTests.cs" />

<!-- tests which are not working well in XHarness + XUnit -->
<Compile Include="System\Runtime\InteropServices\JavaScript\Simple\TimerTests.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\Simple\SimpleMain.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\TimerTests.cs" />
</ItemGroup>

<ItemGroup>
<WasmExtraFilesToDeploy Include="simple.js" />
<WasmExtraFilesToDeploy Include="timers.js" />
</ItemGroup>
<ItemGroup>
<!-- Part of the shared framework but not exposed. -->
<ProjectReference Include="..\src\System.Private.Runtime.InteropServices.JavaScript.csproj" />
</ItemGroup>

<Target Name="SimpleTest" DependsOnTargets="Build">
<Exec WorkingDirectory="$(BaseOutputPath)\$(NetCoreAppCurrent)-Browser-$(Configuration)\browser-wasm\AppBundle" Command="node simple.js" />
</Target>

</Project>
66 changes: 0 additions & 66 deletions ...pServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/Simple/SimpleMain.cs
View file
Open in desktop

This file was deleted.

192 changes: 0 additions & 192 deletions ...pServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/Simple/TimerTests.cs
View file
Open in desktop

This file was deleted.

Loading