Fix the presence of managed build logs on Windows #62446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When analyzing PR failures I noticed that the log / wrn / err / binlog combo only gets produced on Unix runs. I think this is also a bug I made in the build script refactoring, the logging parameters were used for the cmake build instead of the managed build. [I can add a second set of logging parameters for the cmake build phase if needed but I believe it wasn't there before my change.] Thanks Tomas
|
Tagging subscribers to this area: @hoyosjs Issue DetailsWhen analyzing PR failures I noticed that the log / wrn / err / binlog Thanks Tomas
|
Member
Author
|
I have double-checked that the new build log artifacts indeed get published by double-checking the AzDO artifacts. |
jkoritzinsky
approved these changes
Dec 6, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When analyzing PR failures I noticed that the log / wrn / err / binlog
combo only gets produced on Unix runs. I think this is also a bug
I made in the build script refactoring, the logging parameters
were used for the cmake build instead of the managed build.
[I can add a second set of logging parameters for the cmake build
phase if needed but I believe it wasn't there before my change.]
Thanks
Tomas