Skip to content

Don't create multiple large files at the same time #62519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 4 commits into from
Dec 12, 2021
Merged

Don't create multiple large files at the same time #62519

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6c5dea
move existing large file tests into a separate type (no code changes)
adamsitnik Dec 8, 2021
3c82531
don't run the large file tests in parallel
adamsitnik Dec 8, 2021
1fb35d5
use FileOptions.DeleteOnClose to ensure that each test removes it's o…
adamsitnik Dec 9, 2021
259646b
Merge remote-tracking branch 'upstream/main' into largeFileTests
adamsitnik Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't run the large file tests in parallel
  • Loading branch information
@adamsitnik
adamsitnik committed Dec 8, 2021
commit 3c82531eb5e0d773823a0fbe7976f8a508dd1111
13 changes: 3 additions & 10 deletions src/libraries/System.IO.FileSystem/tests/LargeFileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@

namespace System.IO.FileSystem.Tests
{
[OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtime/issues/45954", TestPlatforms.Browser)]
[Collection(nameof(DisableParallelization))] // don't create multiple large files at the same time
public class LargeFileTests : FileSystemTest
{
[Fact]
[OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtime/issues/45954", TestPlatforms.Browser)]
public void ReadFileOver2GB()
{
string path = GetTestFilePath();
Expand All @@ -25,8 +26,6 @@ public void ReadFileOver2GB()
}

[Fact]
[OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtime/issues/45954", TestPlatforms.Browser)]
public void ReadFileOverMaxArrayLength()
{
string path = GetTestFilePath();
Expand All @@ -40,8 +39,6 @@ public void ReadFileOverMaxArrayLength()
}

[Fact]
[OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtime/issues/45954", TestPlatforms.Browser)]
public async Task ReadFileOver2GBAsync()
{
string path = GetTestFilePath();
Expand All @@ -55,8 +52,6 @@ public async Task ReadFileOver2GBAsync()
}

[Fact]
[OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtime/issues/45954", TestPlatforms.Browser)]
public async Task ReadFileOverMaxArrayLengthAsync()
{
string path = GetTestFilePath();
Expand All @@ -70,8 +65,6 @@ public async Task ReadFileOverMaxArrayLengthAsync()
}

[Fact]
[OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtime/issues/45954", TestPlatforms.Browser)]
public void NoInt32OverflowInTheBufferingLogic()
{
const long position1 = 10;
Expand Down