Try to improve HttpConnectionPool lock contention #62794
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffkizer
added
the
NO-MERGE
ghost
assigned
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsTwo related changes: (1) Avoid doing any logging logic under the lock This PR is in progress and only addresses HTTP/1.1 at the moment.
|
Contributor
Author
|
Replaced by #62935 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two related changes:
(1) Avoid doing any logging logic under the lock
(2) Avoid calling TrySetResult on the waiter under the lock -- instead, do this outside the lock and retry as necessary for canceled requests
This PR is in progress and only addresses HTTP/1.1 at the moment.