Skip to content

Making user secrets optional by default #62821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maryamariyan merged 2 commits into from
Dec 15, 2021
Merged

Making user secrets optional by default #62821

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
956dd7e
Making user secrets optional by default
maryamariyan Dec 14, 2021
be9e9a5
update test
maryamariyan Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update test
  • Loading branch information
@maryamariyan
maryamariyan committed Dec 15, 2021
commit be9e9a5d2caf99870c3853f2f08ab4ee29aa305d
6 changes: 3 additions & 3 deletions ...raries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,11 @@ public void AddUserSecrets_ThrowsIfAssemblyAttributeFromType()


[Fact]
public void AddUserSecrets_DoesNotThrowsIfOptional()
public void AddUserSecrets_DoesNotThrowsIfOptionalByDefault()
{
var config = new ConfigurationBuilder()
.AddUserSecrets<string>(optional: true)
.AddUserSecrets(typeof(List<>).Assembly, optional: true)
.AddUserSecrets<string>()
.AddUserSecrets(typeof(List<>).Assembly)
.Build();

Assert.Empty(config.AsEnumerable());
Expand Down