[TODO-List-Cleanup] Refactor fgDebugCheckFlags
#62948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis change does away with one more case of custom traversal logic. Semantic changes have mostly been avoided, with some exceptions:
Note: the Also renamed
|
SingleAccretion
force-pushed
the
TODO-List-Cleanup-fgDebugCheckFlags
branch
2 times, most recently
from
8bc8fac to
2d98637
Compare
SingleAccretion
force-pushed
the
TODO-List-Cleanup-fgDebugCheckFlags
branch
2 times, most recently
from
41aeb3c to
b357b78
Compare
Contributor
Author
|
@dotnet/jit-contrib |
SingleAccretion
force-pushed
the
TODO-List-Cleanup-fgDebugCheckFlags
branch
from
b357b78 to
541904d
Compare
This change does away with one more case of custom traversal logic. Semantic changes have mostly been avoided, with some exceptions: 1) Dead checking of GLOB_REF on ADDR was dropped 2) Dead checking of GLOB_REF on statics was commented out 3) REVERSE_OPS checking was strengthened 4) Flag propagation for calls was also strengthened Note: the GLOB_REF checking was dead because we do not check for "extra" GLOB_REF flags, and the code in question was using the "actual" "treeFlags". Also renamed "treeFlags" to "actualFlags" and "chkFlags" to "expectedFlags" as the handle checking code was apparently confused by the (somewhat unobvious) names and got them swapped.
The code in question was copying GT_LCL_VAR flags to GT_CNS_INT nodes, which is dangerous and not necessary. There is no need to copy the flags in case we didn't create a new constant node as the code under "DONE:" already does that. Found by the new checking code for GTF_REVERSE_OPS.
SingleAccretion
force-pushed
the
TODO-List-Cleanup-fgDebugCheckFlags
branch
from
541904d to
f3dfd94
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does away with one more case of custom traversal logic.
Semantic changes have mostly been avoided, with some exceptions:
GLOB_REFonADDRwas droppedGLOB_REFon statics was commented outREVERSE_OPSchecking was strengthenedNote: the
GLOB_REFchecking was dead because we do not check for "extra" GLOB_REF flags, and the code in question was using the "actual"treeFlags.Also renamed
treeFlagstoactualFlagsandchkFlagstoexpectedFlagsas the handle checking code was apparently confused by the (somewhat unobvious) names and got them swapped.No diffs.