[LoongArch64] Add LoongArch64 support in libunwind. #62979

shushanhf · 2021-12-18T06:25:30Z

add the libunwind for LoongArch64 alone.

am11 · 2021-12-18T07:01:42Z

@shushanhf, thank you. It looks like it is missing changes in:
https://github.com/dotnet/runtime/blob/3b2a700/src/coreclr/pal/src/libunwind/src/CMakeLists.txt
also please add a line Apply https://github.com/libunwind/libunwind/pull/316 in version file:
https://github.com/dotnet/runtime/blob/3b2a700/src/coreclr/pal/src/libunwind/libunwind-version.txt

shushanhf · 2021-12-18T07:51:30Z

@shushanhf, thank you. It looks like it is missing changes in: https://github.com/dotnet/runtime/blob/3b2a700/src/coreclr/pal/src/libunwind/src/CMakeLists.txt also please add a line Apply https://github.com/libunwind/libunwind/pull/316 in version file: https://github.com/dotnet/runtime/blob/3b2a700/src/coreclr/pal/src/libunwind/libunwind-version.txt

Yes, I had moved it from the #62889.
Request for review again.
Thanks

am11 · 2021-12-18T08:18:21Z

@shushanhf, please update libunwind-version.txt with upstream patch link which helps us when we bump the library version. Other than that, it looks good. 👍

cc @janvorli, @jkotas

shushanhf · 2021-12-18T08:54:04Z

@shushanhf, please update libunwind-version.txt with upstream patch link which helps us when we bump the library version. Other than that, it looks good. +1

cc @janvorli, @jkotas

I am very sorry for I forgot add the version.
Had done.

Thanks for your review again !!!

kant2002 · 2021-12-29T06:59:35Z

src/coreclr/pal/src/libunwind/libunwind-version.txt

 Apply https://github.com/libunwind/libunwind/pull/317
+
+For LoongArch64:
+Apply https://github.com/libunwind/libunwind/pull/316


Also should be added Apply https://github.com/libunwind/libunwind/pull/322

At least if I undertand things correctly.

Also should be added Apply https://github.com/libunwind/libunwind/pull/322

I don't see atomic_bool changes in this PR.

I pushed the atomic_bool changes to the upstream.
If need, I will update it within this PR.

merged the https://github.com/libunwind/libunwind/pull/322 by db234e5

@shushanhf can you please add the libunwind/libunwind#322 to the list of "Apply" changes here too?

am11 · 2021-12-29T07:15:55Z

@shushanhf, as agreed previously, everything outside of libunwind directory should go in a separate PR. This PR is about updating libunwind, and not .*unwind.* in this repo (which has a vast surface area encompassing PAL, VM, JIT and beyond...). So please revert commits after e9954d4.

shushanhf · 2021-12-29T07:59:13Z

@am11 OK, I will revert it.

This reverts commit a8fde89. Revert "[LoongArch64] add unwind within the `inc/clrnt.h`." This reverts commit c5e606d.

libunwind/libunwind#322.

shushanhf · 2022-01-08T07:37:54Z

Close & reopen for trigger CI

mangod9 · 2022-02-07T16:18:14Z

Hi @janvorli, could you please take a look so we can merge?

janvorli

LGTM modulo the comment, thank you!

janvorli · 2022-02-07T17:34:44Z

src/coreclr/pal/src/libunwind/libunwind-version.txt

 Apply https://github.com/libunwind/libunwind/pull/317
+
+For LoongArch64:
+Apply https://github.com/libunwind/libunwind/pull/316


@shushanhf can you please add the libunwind/libunwind#322 to the list of "Apply" changes here too?

shushanhf · 2022-02-08T00:50:00Z

LGTM modulo the comment, thank you!
@shushanhf can you please add the libunwind/libunwind#322 to the list of "Apply" changes here too?

OK, I will add it.
Thanks

shushanhf · 2022-02-14T03:36:16Z

Hi @janvorli, could you please take a look so we can merge?

Hi, @mangod9
I had updated the patch.
If need, I can update again.
Thanks.

BruceForstall · 2022-02-14T18:12:48Z

@janvorli @mangod9 Is this ready to merge?

janvorli · 2022-02-14T18:18:40Z

The change looks good, I have already approved it last week with one nit that was fixed since.

…#63489) * [LoongArch64] add the `coreclr/unwinder/loongarch64` from the #62979. * [LoongArch64] replace the `__in` with `_In_`. * [LoongArch64] update the version of the `LICENSE description`. * [LoongArch64] update the macro-define for crossgen2. * [LoongArch64] amend the comment notes. Co-authored-by: qiaopengcheng <[email protected]>

[LoongArch64] Add LoongArch64 support in libunwind.

bf3793a

ghost added area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member labels Dec 18, 2021

shushanhf mentioned this pull request Dec 18, 2021

[LoongArch64] add the coreclr/pal directory #62887

Merged

[LoongArch64] add libunwind/src/CMakeLists.txt from #62889.

16dc419

[LoongArch64] add libunwind-version for LoongArch64.

e9954d4

qiaopengcheng added 2 commits December 22, 2021 15:06

[LoongArch64] add unwinder/loongarch64/ directory.

a8fde89

[LoongArch64] add unwind within the inc/clrnt.h.

c5e606d

jkotas added the arch-loongarch64 label Dec 22, 2021

kant2002 reviewed Dec 29, 2021

View reviewed changes

qiaopengcheng added 2 commits December 29, 2021 16:03

Revert "[LoongArch64] add unwinder/loongarch64/ directory."

98b471e

This reverts commit a8fde89. Revert "[LoongArch64] add unwind within the `inc/clrnt.h`." This reverts commit c5e606d.

[LoongArch64] Fixed the compiling error by

db234e5

libunwind/libunwind#322.

shushanhf mentioned this pull request Jan 7, 2022

[LoongArch64] add the coreclr/unwinder/loongarch64 from the #62979. #63489

Merged

shushanhf closed this Jan 8, 2022

shushanhf reopened this Jan 8, 2022

janvorli approved these changes Feb 7, 2022

View reviewed changes

[LoongArch64] amend the "Apply info" for LoongArch64.

de0cbe3

BruceForstall added this to the 7.0.0 milestone Feb 14, 2022

BruceForstall merged commit 1615de6 into dotnet:main Feb 15, 2022

ghost locked as resolved and limited conversation to collaborators Mar 17, 2022

shushanhf deleted the feature/loongarch64/libunwind branch May 11, 2022 01:13

[LoongArch64] Add LoongArch64 support in libunwind. #62979

[LoongArch64] Add LoongArch64 support in libunwind. #62979

Uh oh!

Conversation

shushanhf commented Dec 18, 2021

Uh oh!

am11 commented Dec 18, 2021

Uh oh!

shushanhf commented Dec 18, 2021

Uh oh!

am11 commented Dec 18, 2021

Uh oh!

shushanhf commented Dec 18, 2021

Uh oh!

kant2002 Dec 29, 2021

Choose a reason for hiding this comment

Uh oh!

kant2002 Dec 29, 2021

Choose a reason for hiding this comment

Uh oh!

am11 Dec 29, 2021

Choose a reason for hiding this comment

Uh oh!

shushanhf Dec 29, 2021

Choose a reason for hiding this comment

Uh oh!

shushanhf Dec 29, 2021

Choose a reason for hiding this comment

Uh oh!

janvorli Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

am11 commented Dec 29, 2021

Uh oh!

shushanhf commented Dec 29, 2021

Uh oh!

shushanhf commented Jan 8, 2022

Uh oh!

mangod9 commented Feb 7, 2022

Uh oh!

janvorli left a comment

Choose a reason for hiding this comment

Uh oh!

janvorli Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

shushanhf commented Feb 8, 2022

Uh oh!

shushanhf commented Feb 14, 2022

Uh oh!

BruceForstall commented Feb 14, 2022

Uh oh!

janvorli commented Feb 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants