Various WASM AOT changes #62997
Merged
Various WASM AOT changes #62997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines failed to run 1 pipeline(s). |
This can be used to trace values from AOT code during runtime debugging.
Previously, a try-catch clause was added to the vector Alloc wrappers to convert the OverflowException thrown by the .ovf opcodes to an OutOfMemoryException. This could cause EH problems on wasm since on wasm no AOTed code should contain clauses, but this wrapper was still AOTed for performance reasons. Instead, add a new CIL opcode to make the .ovf opcodes throw the OutOfMemoryException directly.
It can't handle the new bblocks added by the inline rgctx fetch code.
The slowpath contained a try-catch clause, preventing Array.Copy () from being AOTed on WASM.
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Comment was made before the most recent commit for PR 62997 in repo dotnet/runtime |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines failed to run 1 pipeline(s). |
kasperk81
reviewed
Dec 19, 2021
Comment on lines
144
to
+147
| if (FastCopy(sourceArray, sourceIndex, destinationArray, destinationIndex, length)) | ||
| return; | ||
|
|
||
| CopySlow(sourceArray, sourceIndex, destinationArray, destinationIndex, length, reliable); |
Contributor
There was a problem hiding this comment.
CopySlow -> SlowCopy or rename the other one to CopyFast?
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines failed to run 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
requested review from
BrzVlad,
EgorBo,
SamMonoRT,
imhameed,
marek-safar and
naricc
as code owners
lambdageek
approved these changes
Dec 20, 2021
imhameed
approved these changes
Dec 20, 2021
Contributor
Author
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Failures appear unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.