Skip to content

Conversation

@antmeehan
Copy link
Contributor

Modifies the logging in LoggingHttpMessageHandler and LoggingScopeHttpMessageHandler to log the AbsoluteUri so the unescaped Uri is logged.

Fix #62894

@ghost ghost added area-Extensions-HttpClientFactory community-contribution Indicates that the PR has been added by a community member labels Dec 20, 2021
@ghost
Copy link

ghost commented Dec 20, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Modifies the logging in LoggingHttpMessageHandler and LoggingScopeHttpMessageHandler to log the AbsoluteUri so the unescaped Uri is logged.

Fix #62894

Author: antmeehan
Assignees: -
Labels:

area-Extensions-HttpClientFactory

Milestone: -

@dnfadmin
Copy link

dnfadmin commented Dec 20, 2021

CLA assistant check
All CLA requirements met.

@antmeehan antmeehan force-pushed the users/meehana/http-logging-62894 branch 2 times, most recently from 9f6dde0 to 03e8341 Compare December 21, 2021 00:25
@antmeehan antmeehan force-pushed the users/meehana/http-logging-62894 branch from 03e8341 to 2fa1722 Compare January 10, 2022 13:27
…tnet#62894)

Modifies the logging in 
LoggingHttpMessageHandler and LoggingScopeHttpMessageHandler to log the AbsoluteUri so the unescaped Uri is logged
@antmeehan antmeehan force-pushed the users/meehana/http-logging-62894 branch from 2fa1722 to 212e048 Compare January 10, 2022 13:52
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@CarnaViire CarnaViire merged commit b8a8c7a into dotnet:main Jan 11, 2022
@antmeehan antmeehan deleted the users/meehana/http-logging-62894 branch January 12, 2022 12:17
@ghost ghost locked as resolved and limited conversation to collaborators Mar 1, 2022
@karelz karelz added this to the 7.0.0 milestone Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Extensions-HttpClientFactory community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LoggingHttpMessageHandler should log unescaped URL in log message

6 participants