-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[release/6.0-maui] Add back HAVE_SYS_ZLIB support #63359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0-maui] Add back HAVE_SYS_ZLIB support #63359
Conversation
|
/cc @thaystg |
src/mono/cmake/configure.cmake
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is copied from
but I'm not sure if that's necessary.
|
LGTM, the embedded pdb is now working on ios. |
|
If memory serves, this stuff was disabled because in some scenarios it was inexplicably broken. So if it's legit working, then fine, seal of approval. But it really needs every viable permutation double-checked |
|
As far as I remember, what was inexplicably broken, was fixed here: mono/mono#18895 |
|
Awesome, thanks Thays |
|
I don't understand this |
Likely caused by #62787. I thought the failures were unrelated and missed that one. I'll look into it. |
In particular this re-enables embedded PDB support on iOS and Android
a4ecc52 to
a62b714
Compare
|
@lambdageek should this go to release/6.0 as well? |
@lewing I don't see a lot of motivation for it. Note that embedded PDB support for WASM was always enabled (it was already part of the ifdef). |
It'll make it to release/6.0 when we merge it with the Maui branch commits. |
In particular this re-enables embedded PDB support on iOS and Android
The corresponding PR for
mainis #63365