Skip to content

Conversation

@lambdageek
Copy link
Member

@lambdageek lambdageek commented Jan 4, 2022

In particular this re-enables embedded PDB support on iOS and Android

The corresponding PR for main is #63365

@ghost ghost added the area-Build-mono label Jan 4, 2022
@ghost ghost assigned lambdageek Jan 4, 2022
@lambdageek
Copy link
Member Author

/cc @thaystg

Comment on lines +88 to +92
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thaystg
Copy link
Member

thaystg commented Jan 4, 2022

LGTM, the embedded pdb is now working on ios.

@lambdageek lambdageek marked this pull request as ready for review January 4, 2022 21:44
@lambdageek lambdageek changed the title 6.0-maui: Add back HAVE_SYS_ZLIB support [release/6.0-maui] Add back HAVE_SYS_ZLIB support Jan 4, 2022
@directhex
Copy link
Contributor

If memory serves, this stuff was disabled because in some scenarios it was inexplicably broken. So if it's legit working, then fine, seal of approval. But it really needs every viable permutation double-checked

@thaystg
Copy link
Member

thaystg commented Jan 5, 2022

As far as I remember, what was inexplicably broken, was fixed here: mono/mono#18895

@directhex
Copy link
Contributor

Awesome, thanks Thays

@lambdageek
Copy link
Member Author

I don't understand this runtime (Build Browser wasm Release AllSubsets_Mono_WasmBuildTests) failure:

src/libraries/workloads-testing.targets(105,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "InstallWorkloadFromArtifacts" task failed unexpectedly.
System.IO.DirectoryNotFoundException: Could not find a part of the path '/__w/1/s/artifacts/bin/dotnet-workload/sdk-manifests/6.0.200'.
   at System.IO.Enumeration.FileSystemEnumerator`1.CreateDirectoryHandle(String path, Boolean ignoreNotFound)
   at System.IO.Enumeration.FileSystemEnumerator`1.Init()
   at System.IO.Enumeration.FileSystemEnumerableFactory.UserDirectories(String directory, String expression, EnumerationOptions options)
   at System.IO.Directory.InternalEnumeratePaths(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options)
   at System.IO.Directory.EnumerateDirectories(String path, String searchPattern, EnumerationOptions enumerationOptions)
   at Microsoft.Workload.Build.Tasks.InstallWorkloadFromArtifacts.FindSubDirIgnoringCase(String parentDir, String dirName) in /_/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs:line 168
   at Microsoft.Workload.Build.Tasks.InstallWorkloadFromArtifacts.InstallWorkloadManifest(String name, String version, String nugetConfigContents, Boolean stopOnMissing) in /_/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs:line 101
   at Microsoft.Workload.Build.Tasks.InstallWorkloadFromArtifacts.Execute() in /_/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs:line 58
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

@steveisok
Copy link
Member

I don't understand this runtime (Build Browser wasm Release AllSubsets_Mono_WasmBuildTests) failure:

Likely caused by #62787. I thought the failures were unrelated and missed that one. I'll look into it.

In particular this re-enables embedded PDB support on iOS and Android
@steveisok steveisok merged commit a9d5ccd into dotnet:release/6.0-maui Jan 10, 2022
@lewing
Copy link
Member

lewing commented Jan 10, 2022

@lambdageek should this go to release/6.0 as well?

@lambdageek
Copy link
Member Author

@lambdageek should this go to release/6.0 as well?

@lewing I don't see a lot of motivation for it. Note that embedded PDB support for WASM was always enabled (it was already part of the ifdef).

@steveisok
Copy link
Member

@lambdageek should this go to release/6.0 as well?

@lewing I don't see a lot of motivation for it. Note that embedded PDB support for WASM was always enabled (it was already part of the ifdef).

It'll make it to release/6.0 when we merge it with the Maui branch commits.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants