Skip to content

Reduce buffer size used in XmlReader when using Async mode #63459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krwq merged 1 commit into from
Jan 24, 2022
Merged

Reduce buffer size used in XmlReader when using Async mode #63459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/libraries/System.Private.Xml/src/System/Xml/Core/XmlReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ public abstract partial class XmlReader : IDisposable
internal const int BiggerBufferSize = 8192;
internal const int MaxStreamLengthForDefaultBufferSize = 64 * 1024; // 64kB

internal const int AsyncBufferSize = 64 * 1024; //64KB
// Chosen to be small enough that the character buffer in XmlTextReader when using Async = true
// is not allocated on the Large Object Heap (LOH)
internal const int AsyncBufferSize = 32 * 1024;

// Settings
public virtual XmlReaderSettings? Settings => null;
Expand Down