Skip to content

Remove leading and trailing white-spaces from section name #63549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 2 commits into from
Jan 11, 2022
Merged

Remove leading and trailing white-spaces from section name #63549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8340cb1
Reproduce the issue with spaces around the section name
mapogolions Jan 9, 2022
0bb584e
Remove leading and trailing whitespaces from section name
mapogolions Jan 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/Microsoft.Extensions.Configuration.Ini/src/IniStreamConfigurationProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ public static IDictionary<string, string> Read(Stream stream)
{
// remove the brackets
#if NET
sectionPrefix = string.Concat(line.AsSpan(1, line.Length - 2), ConfigurationPath.KeyDelimiter);
sectionPrefix = string.Concat(line.AsSpan(1, line.Length - 2).Trim(), ConfigurationPath.KeyDelimiter);
#else
sectionPrefix = line.Substring(1, line.Length - 2) + ConfigurationPath.KeyDelimiter;
sectionPrefix = line.Substring(1, line.Length - 2).Trim() + ConfigurationPath.KeyDelimiter;
#endif
continue;
}
Expand Down
22 changes: 22 additions & 0 deletions src/libraries/Microsoft.Extensions.Configuration.Ini/tests/IniConfigurationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,28 @@ public void SupportAndIgnoreComments()
Assert.Equal("MySql", iniConfigSrc.Get("Data:Inventory:Provider"));
}

[Fact]
public void ShouldRemoveLeadingAndTrailingWhiteSpacesFromKeyAndValue()
{
var ini = "[section]\n" +
" \t key \t = \t value\t ";
var iniConfigSrc = new IniConfigurationProvider(new IniConfigurationSource());
iniConfigSrc.Load(TestStreamHelpers.StringToStream(ini));

Assert.Equal("value", iniConfigSrc.Get("section:key"));
}

[Fact]
public void ShouldRemoveLeadingAndTrailingWhiteSpacesFromSectionName()
{
var ini = "[ \t section \t ]\n" +
"key=value";
var iniConfigSrc = new IniConfigurationProvider(new IniConfigurationSource());
iniConfigSrc.Load(TestStreamHelpers.StringToStream(ini));

Assert.Equal("value", iniConfigSrc.Get("section:key"));
}

[Fact]
public void ThrowExceptionWhenFoundInvalidLine()
{
Expand Down