Skip to content

[Android] Throw PNSE for unavailable network information #63633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonrozsival merged 10 commits into from
Jan 13, 2022
Merged

[Android] Throw PNSE for unavailable network information #63633

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6f74472
Update tests
simonrozsival Jan 11, 2022
27bc123
Add android specific implementation
simonrozsival Jan 11, 2022
6b5e5f3
Add UnsupportedOSPlatform attributes
simonrozsival Jan 11, 2022
5b07b53
Fix typo
simonrozsival Jan 11, 2022
11b1ea5
Remove unnecessary file reference
simonrozsival Jan 11, 2022
f9203da
Clean-up code
simonrozsival Jan 12, 2022
bc2ba27
Minor code clean-up
simonrozsival Jan 12, 2022
c133682
Remove dictionary
simonrozsival Jan 12, 2022
77e4c88
Refactoring
simonrozsival Jan 12, 2022
baeabae
Revert comment change
simonrozsival Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor code clean-up
  • Loading branch information
@simonrozsival
simonrozsival committed Jan 12, 2022
commit bc2ba2751042ae84121aa9bc6c03692f3f049f9a
11 changes: 3 additions & 8 deletions ....Net.NetworkInformation/src/System/Net/NetworkInformation/AndroidIPInterfaceProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,13 @@ public AndroidIPInterfaceProperties(AndroidNetworkInterface ani)
_ipv6Properties = new AndroidIPv6InterfaceProperties(ani);
}

public override bool IsDynamicDnsEnabled => throw new PlatformNotSupportedException(SR.net_InformationUnavailableOnPlatform);
public override IPv4InterfaceProperties GetIPv4Properties() => _ipv4Properties;
public override IPv6InterfaceProperties GetIPv6Properties() => _ipv6Properties;

public override bool IsDynamicDnsEnabled => throw new PlatformNotSupportedException(SR.net_InformationUnavailableOnPlatform);
public override IPAddressInformationCollection AnycastAddresses => throw new PlatformNotSupportedException(SR.net_InformationUnavailableOnPlatform);

public override GatewayIPAddressInformationCollection GatewayAddresses => throw new PlatformNotSupportedException(SR.net_InformationUnavailableOnPlatform);

public override IPAddressCollection DhcpServerAddresses => throw new PlatformNotSupportedException(SR.net_InformationUnavailableOnPlatform);

public override IPAddressCollection WinsServersAddresses => throw new PlatformNotSupportedException(SR.net_InformationUnavailableOnPlatform);

public override IPv4InterfaceProperties GetIPv4Properties() => _ipv4Properties;

public override IPv6InterfaceProperties GetIPv6Properties() => _ipv6Properties;
}
}