Skip to content

[release/6.0-vs4mac] Fix the MacOS remote unwinder for VS4Mac #63758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
safern merged 2 commits into from
Jan 13, 2022
Merged

[release/6.0-vs4mac] Fix the MacOS remote unwinder for VS4Mac #63758

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9422c42
Fix the MacOS remote unwinder for VS4Mac
Jan 4, 2022
c81e00d
Fix native frame unwind in syscall on arm64 for VS4Mac crash report
Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix the MacOS remote unwinder for VS4Mac 
The wrong module was being passed to the remote unwinder because the load bias for shared modules
was being calculated incorrectly.

Issue: #63309
  • Loading branch information
Mike McLaughlin authored and github-actions committed Jan 13, 2022
commit 9422c42fe6b0a487ed2776edf651b1584d6008a3
5 changes: 2 additions & 3 deletions src/coreclr/debug/dbgutil/machoreader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,8 @@ MachOModule::ReadLoadCommands()
m_segments.push_back(segment);

// Calculate the load bias for the module. This is the value to add to the vmaddr of a
// segment to get the actual address. For shared modules, this is 0 since those segments
// are absolute address.
if (segment->fileoff == 0 && segment->filesize > 0)
// segment to get the actual address.
if (strcmp(segment->segname, SEG_TEXT) == 0)
{
m_loadBias = m_baseAddress - segment->vmaddr;
}
Expand Down