Skip to content

Add JIT support for control-flow guard on x64 and arm64 #63763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 31 commits into from
Feb 8, 2022
Merged

Add JIT support for control-flow guard on x64 and arm64 #63763

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
7075393
Implement control-flow guard support for x64 and arm64
jakobbotsch Jan 20, 2022
dfa28e1
Pipe through the flag to NativeAOT compiler
MichalStrehovsky Jan 19, 2022
e07386f
Represent the helper as an indirection
MichalStrehovsky Jan 19, 2022
fb293b9
Add some verbose output for moved late args
jakobbotsch Jan 20, 2022
4665ea0
Add GT_FIELD_LIST to assert
jakobbotsch Jan 20, 2022
b19e47d
Fix placement moving logic for GT_FIELD_LIST
jakobbotsch Jan 20, 2022
0a221c5
Add more general invariance check
jakobbotsch Jan 20, 2022
6f68c08
Fix release build
jakobbotsch Jan 20, 2022
acf223b
Fix IsInvariant check
jakobbotsch Jan 20, 2022
ef465fb
Add a dTreeRange helper
jakobbotsch Jan 20, 2022
a7a6415
Skip local for call target
jakobbotsch Jan 20, 2022
17e22f0
Add missing parentheses
jakobbotsch Jan 20, 2022
21e5858
Rename IsInvariant -> IsInvariantInRange
jakobbotsch Jan 20, 2022
8baddf0
Another build fix
jakobbotsch Jan 20, 2022
092364e
Fix register for ARM64 dispatcher
jakobbotsch Jan 21, 2022
ce46dcf
Add section on CFG to the clr-abi docs
jakobbotsch Jan 21, 2022
451aaa6
Fix arm64 validator trashed registers and update lowering comment
jakobbotsch Jan 21, 2022
6df00a1
Add line to disasm when CFG is enabled
jakobbotsch Jan 21, 2022
69d3b5f
Add a workaround for reporting dead GC pointer regs too early when th…
jakobbotsch Feb 1, 2022
ca5c444
Merge branch 'main' of github.com:dotnet/runtime into support-cfg
jakobbotsch Feb 1, 2022
6659597
Fix some comments
jakobbotsch Feb 1, 2022
866bcce
Revert "Add a workaround for reporting dead GC pointer regs too early…
jakobbotsch Feb 2, 2022
bd1a7ec
Move all GT_PUTARG_* nodes behind validator to fix GC reporting
jakobbotsch Feb 2, 2022
f9ad18c
Remove unused variable
jakobbotsch Feb 2, 2022
1f42b99
Add a CFG + GC stress job
jakobbotsch Feb 4, 2022
2eeecde
Clarify expected use of CFG
jakobbotsch Feb 8, 2022
f25ba52
Assert we do not lower dispatcher as CFG call
jakobbotsch Feb 8, 2022
47409ba
Update jit-ee interface GUID
jakobbotsch Feb 8, 2022
13233bf
Remove note about preallocating arg for dispatcher
jakobbotsch Feb 8, 2022
447bca8
Remove another TODO
jakobbotsch Feb 8, 2022
95defd6
Fix an assert
jakobbotsch Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused variable
  • Loading branch information
@jakobbotsch
jakobbotsch committed Feb 2, 2022
commit f9ad18c5175f053c0b1668c0f4ece51c729b26c8
3 changes: 1 addition & 2 deletions src/coreclr/jit/lower.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class Lowering final : public Phase
{
public:
inline Lowering(Compiler* compiler, LinearScanInterface* lsra)
: Phase(compiler, PHASE_LOWERING), vtableCallTemp(BAD_VAR_NUM), m_cfgCallTargetTemp(BAD_VAR_NUM)
: Phase(compiler, PHASE_LOWERING), vtableCallTemp(BAD_VAR_NUM)
{
m_lsra = (LinearScan*)lsra;
assert(m_lsra);
Expand Down Expand Up @@ -615,7 +615,6 @@ class Lowering final : public Phase

LinearScan* m_lsra;
unsigned vtableCallTemp; // local variable we use as a temp for vtable calls
unsigned m_cfgCallTargetTemp; // local variable used to evaluate call target into for CFG calls
SideEffectSet m_scratchSideEffects; // SideEffectSet used for IsSafeToContainMem and isRMWIndirCandidate
BasicBlock* m_block;
};
Expand Down