Skip to content

Conversation

@mikem8361
Copy link
Contributor

Issue: #64011

Customer Impact

VS4Mac crashes when debugging VS4Mac.

Testing

VS4Mac team verified that it no longer crashes.

Risk

Low.

Issue: dotnet#64011

# Customer Impact

VS4Mac crashes when debugging VS4Mac.

# Testing

VS4Mac team verified that it no longer crashes.

# Risk

Low.
@mikem8361 mikem8361 requested review from hoyosjs and noahfalk January 21, 2022 03:30
@mikem8361 mikem8361 self-assigned this Jan 21, 2022
@ghost
Copy link

ghost commented Jan 21, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Issue: #64011

Customer Impact

VS4Mac crashes when debugging VS4Mac.

Testing

VS4Mac team verified that it no longer crashes.

Risk

Low.

Author: mikem8361
Assignees: mikem8361
Labels:

area-Diagnostics-coreclr

Milestone: -

@mikem8361
Copy link
Contributor Author

@noahfalk can you approve this release/6.0 PR?

@marek-safar marek-safar added the Servicing-consider Issue for next servicing release review label Jan 21, 2022
@marek-safar marek-safar added this to the 6.0.x milestone Jan 21, 2022
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We should take for consideration in 6.0.x

@jeffschwMSFT jeffschwMSFT changed the title Fix crash when VS4Mac is debugging VS4Mac arm64 [release/6.0] Fix crash when VS4Mac is debugging VS4Mac arm64 Jan 25, 2022
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 25, 2022
@leecow leecow modified the milestones: 6.0.x, 6.0.3 Jan 25, 2022
@mikem8361
Copy link
Contributor Author

This PR will get merged for 6.0.3 servicing? I don't want it to be forgotten.

@jeffschwMSFT
Copy link
Member

The branch should be open this week for 6.0.3.

cc @safern

@safern safern merged commit 2e71ad4 into dotnet:release/6.0 Feb 7, 2022
@safern
Copy link
Member

safern commented Feb 7, 2022

It took a little longer to open the branch due to some infra related hiccups we hit when updating our branding, but it is now open until 4pm today.

@mikem8361 mikem8361 deleted the vs4mac_crash60 branch February 16, 2022 17:17
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants