Skip to content

[release/6.0-maui] Android remove backward timezones #64228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveisok merged 13 commits into from
Jan 24, 2022
Merged

[release/6.0-maui] Android remove backward timezones #64228

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
aaed54e
[libraries][Android] Filter out backward timezone IDs using tzlookup …
mdh1418 Jan 19, 2022
e616d00
[tests] Add TimeZoneInfo Test to detect Backward TimeZones
mdh1418 Jan 20, 2022
3c6fb6f
Address feedback
mdh1418 Jan 20, 2022
4f58379
Address more feedback
mdh1418 Jan 20, 2022
0df3e63
[libraries][Android] Add isBackwards in lieu of removing timezone ids
mdh1418 Jan 20, 2022
a68e071
Remove unneeded strings.resx additions
mdh1418 Jan 21, 2022
ca04d45
Temporarily show timezone displayNames in NoBackwardTimeZones
mdh1418 Jan 21, 2022
c0c7c59
Figure out backwards IDs on linux and maybe windows
mdh1418 Jan 21, 2022
a65ba3a
[libraries] ActiveIssue NoBackwardTimeZones for Linux Arm64
mdh1418 Jan 21, 2022
99057e7
Cleanup
mdh1418 Jan 21, 2022
2dc8726
Skip test with TestPlatforms instead
mdh1418 Jan 21, 2022
e2cdbc4
Optimize further by not allocating a list for GetTimeZoneIDs
mdh1418 Jan 24, 2022
0e1a8da
Fix indexing
mdh1418 Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unneeded strings.resx additions
  • Loading branch information
@mdh1418
mdh1418 authored and github-actions committed Jan 24, 2022
commit a68e07120a3f7cbdb42d5e62a70ef1acb29847c7
6 changes: 0 additions & 6 deletions src/libraries/System.Private.CoreLib/src/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2593,9 +2593,6 @@
<data name="InvalidOperation_TimerAlreadyClosed" xml:space="preserve">
<value>The Timer was already closed using an incompatible Dispose method.</value>
</data>
<data name="InvalidOperation_TimeZoneLookupParsing" xml:space="preserve">
<value>Internal Error in parsing tzlookup file "{1}".</value>
</data>
<data name="InvalidOperation_TypeCannotBeBoxed" xml:space="preserve">
<value>The given type cannot be boxed.</value>
</data>
Expand Down Expand Up @@ -3025,9 +3022,6 @@
<data name="OperationCanceled" xml:space="preserve">
<value>The operation was canceled.</value>
</data>
<data name="OutOfMemory_TimeZoneLookupParsing" xml:space="preserve">
<value>There is insufficient memory to allocate a buffer to read tzlookup file "{1}".</value>
</data>
<data name="Overflow_Byte" xml:space="preserve">
<value>Value was either too large or too small for an unsigned byte.</value>
</data>
Expand Down