Skip to content

Expand System.Runtime.InteropServices.NFloat to support the APIs required by Xamarin #64234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 7 commits into from
Jan 28, 2022
Merged

Expand System.Runtime.InteropServices.NFloat to support the APIs required by Xamarin #64234

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1e9c3bd
Expand System.Runtime.InteropServices.NFloat to support the APIs requ…
tannergooding Jan 24, 2022
5e25e30
Apply suggestions from code review
tannergooding Jan 25, 2022
4b38c4e
Adding NFloat tests (p1)
tannergooding Jan 26, 2022
fa7dcb7
Temporarily disable negative conversions involving nfloat->nint
tannergooding Jan 27, 2022
e816cca
Adjusting the skip condition for the Mono failures
tannergooding Jan 27, 2022
6113d94
Adding additional tests covering the NFloat.Is* APIs
tannergooding Jan 27, 2022
5cac24c
Fixing the IsNormal and IsSubnormal test to account for 64-bit vs 32-bit
tannergooding Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
  • Loading branch information
@tannergooding @rolfbjarne
tannergooding and rolfbjarne authored Jan 25, 2022
commit 5e25e30e3809a4b065fe16524780aa83e8f255db
4 changes: 2 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/NFloat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public double Value
/// <param name="right">The value to compare with <paramref name="left" />.</param>
/// <returns><c>true</c> if <paramref name="left" /> is less than or equal to <paramref name="right" />; otherwise, <c>false</c>.</returns>
[NonVersionable]
public static bool operator <=(NFloat left, NFloat right) => left._value >= right._value;
public static bool operator <=(NFloat left, NFloat right) => left._value <= right._value;

/// <summary>Compares two values to determine which is greater.</summary>
/// <param name="left">The value to compare with <paramref name="right" />.</param>
Expand All @@ -213,7 +213,7 @@ public double Value
/// <param name="right">The value to compare with <paramref name="left" />.</param>
/// <returns><c>true</c> if <paramref name="left" /> is greater than or equal to <paramref name="right" />; otherwise, <c>false</c>.</returns>
[NonVersionable]
public static bool operator >=(NFloat left, NFloat right) => left._value <= right._value;
public static bool operator >=(NFloat left, NFloat right) => left._value >= right._value;

//
// Explicit Convert To NFloat
Expand Down