Skip to content

Override all Read methods in NullTextReader and NullStreamReader #64301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 9 commits into from
Jan 27, 2022
Merged

Override all Read methods in NullTextReader and NullStreamReader #64301

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
426c041
Override all Read methods in NullTextReader and NullStreamReader.
bgrainger Jan 23, 2022
9b2f3c1
Cache Task.FromResult("").
bgrainger Jan 26, 2022
c6dd80f
Remove cached Task<string>.
bgrainger Jan 26, 2022
e94886f
Improve tests based on feedback.
bgrainger Jan 26, 2022
728a28b
Replace NullTextReader with NullStreamReader.
bgrainger Jan 26, 2022
d710586
Remove extra newline.
bgrainger Jan 26, 2022
1d3e130
Run null TextReader tests on unique instances.
bgrainger Jan 26, 2022
03b3696
Create a NullStreamReader instance to back TextReader.Null.
bgrainger Jan 26, 2022
80dad33
Apply suggestions from code review
adamsitnik Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run null TextReader tests on unique instances.
  • Loading branch information
@bgrainger
bgrainger committed Jan 26, 2022
commit 1d3e13064882fb706e36afa960cbb8f9c870f9f2
13 changes: 4 additions & 9 deletions src/libraries/System.IO/tests/Stream/Stream.NullTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,15 +242,10 @@ public void DisposeAsync_Nop()
Stream.Null.Write(new byte[42]); // still usable
}

public static IEnumerable<object[]> NullReaders
{
get
{
yield return new object[] { TextReader.Null };
yield return new object[] { StreamReader.Null };
yield return new object[] { StringReader.Null };
}
}
public static IEnumerable<object[]> NullReaders =>
new[] { TextReader.Null, StreamReader.Null, StringReader.Null }
.Distinct()
.Select(x => new object[] { x });

public static IEnumerable<object[]> NullWriters
{
Expand Down