Skip to content

PoC TLS resume on Linux client #64369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wfurt merged 17 commits into from
Mar 25, 2022
Merged

PoC TLS resume on Linux client #64369

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e52b12f
TLS resume on client
wfurt Jan 27, 2022
1811028
Merge branch 'main' of https://github.com/dotnet/runtime into tlsClie…
wfurt Jan 27, 2022
f9a2eab
shim functions introduced in 1.1.1
wfurt Feb 1, 2022
9b87b4e
add missing struct
wfurt Feb 1, 2022
fd5635d
disable resume on old OpenSSL
wfurt Feb 3, 2022
99240d4
feedback from review
wfurt Feb 4, 2022
342d916
fix source build
wfurt Feb 4, 2022
acd3b46
Merge branch 'main' of https://github.com/dotnet/runtime into tlsClie…
wfurt Feb 18, 2022
51ec560
update comment
wfurt Feb 18, 2022
dc453d4
Merge branch 'main' of https://github.com/dotnet/runtime into tlsClie…
wfurt Feb 25, 2022
2170ec4
feedback from review
wfurt Mar 3, 2022
929e5c7
Merge branch 'main' of https://github.com/dotnet/runtime into tlsClie…
wfurt Mar 3, 2022
c2c8580
feedback from review
wfurt Mar 3, 2022
d2ab19b
Merge branch 'main' of https://github.com/dotnet/runtime into tlsClie…
wfurt Mar 3, 2022
576d4d5
avoild client resume on old OpenSSL
wfurt Mar 5, 2022
876b5a0
Merge branch 'main' of https://github.com/dotnet/runtime into tlsClie…
wfurt Mar 7, 2022
434ab42
Merge branch 'main' of https://github.com/dotnet/runtime into tlsClie…
wfurt Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comment
  • Loading branch information
@wfurt
wfurt committed Feb 18, 2022
commit 51ec5607461e62527891c744e8023c5f80d92f03
3 changes: 1 addition & 2 deletions src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@ private static unsafe void RemoveSessionCallback(IntPtr ctx, IntPtr session)
IntPtr ptr = Ssl.SslCtxGetData(ctx);
if (ptr == IntPtr.Zero)
{
// Same as above, SafeSslContextHandle could be released while OpenSSL still holds refferecne.
// Same as above, SafeSslContextHandle could be released while OpenSSL still holds reference.
return;
}

Expand All @@ -733,7 +733,6 @@ private static unsafe void RemoveSessionCallback(IntPtr ctx, IntPtr session)
return;
}

//string? name = Marshal.PtrToStringAnsi(Ssl.SessionGetHostname(session));a
IntPtr name = Ssl.SessionGetHostname(session);
Debug.Assert(name != IntPtr.Zero);
ctxHandle.RemoveSession(name, session);
Expand Down