Skip to content

Conversation

@adamsitnik
Copy link
Member

While experimenting with #61676 I've removed the file truncation in File.CopyTo for overwrite == true and all tests were passing.

@ghost
Copy link

ghost commented Jan 31, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

While experimenting with #61676 I've removed the file truncation in File.CopyTo for overwrite == true and all tests were passing.

Author: adamsitnik
Assignees: -
Labels:

area-System.IO

Milestone: -

@adamsitnik adamsitnik requested a review from jozkee January 31, 2022 14:52
@adamsitnik adamsitnik added this to the 7.0.0 milestone Jan 31, 2022
@adamsitnik adamsitnik added the test-enhancement Improvements of test source code label Jan 31, 2022
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Dan's comment, LGTM

@adamsitnik adamsitnik merged commit d201ebb into dotnet:main Jan 31, 2022
@adamsitnik adamsitnik deleted the fileCopyTestGap branch January 31, 2022 20:00
@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.IO test-enhancement Improvements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants