Skip to content

[wasm] Revert "Disable InspectVariableBeforeAndAfterAssignment test (#64546)" #64574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
radical merged 1 commit into from
Feb 1, 2022
Merged

[wasm] Revert "Disable InspectVariableBeforeAndAfterAssignment test (#64546)" #64574

radical merged 1 commit into from
Feb 1, 2022

Conversation

@radical
Copy link
Member

@radical radical commented Jan 31, 2022

This reverts commit 09f681f.

This isn't needed as the tests are being run only in runtime-staging
now. And this commit itself doesn't build.

@radical
Revert "Disable InspectVariableBeforeAndAfterAssignment test (dotnet#…
5b61460 
…64546)"

This reverts commit 09f681f.

This isn't needed as the tests are being run only in `runtime-staging`
now. And this commit itself doesn't build.
@radical radical requested a review from marek-safar as a code owner January 31, 2022 22:08
@ghost ghost added the area-Debugger-mono label Jan 31, 2022
@ghost ghost assigned radical Jan 31, 2022
@ghost
Copy link

ghost commented Jan 31, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

This reverts commit 09f681f.

This isn't needed as the tests are being run only in runtime-staging
now. And this commit itself doesn't build.

Author: radical
Assignees: radical
Labels:

area-Debugger-mono
Milestone: -

@radical radical requested review from lewing and sbomer January 31, 2022 22:08
@radical radical added the arch-wasm WebAssembly architecture label Jan 31, 2022
@ghost
Copy link

ghost commented Jan 31, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This reverts commit 09f681f.

This isn't needed as the tests are being run only in runtime-staging
now. And this commit itself doesn't build.

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@radical radical requested a review from safern January 31, 2022 22:09
@radical radical merged commit 4466525 into dotnet:main Feb 1, 2022
@radical radical deleted the revert-test-disable branch February 1, 2022 01:00
@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sbomer sbomer sbomer approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@safern safern Awaiting requested review from safern

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radical @sbomer