Skip to content

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented Feb 1, 2022

In #64251, I made a fix to catch decoding issues, but seems that the problem also occurs when printing those characters. On quick search reveals this problem and proposals to fix them, but the simplest thing to do in our situation would be to just return empty string if such errors occur. So, I converted the decode_string method to decode_and_print which will catch the printing errors as well.

Fixes: #64575

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 1, 2022
@ghost ghost assigned kunalspathak Feb 1, 2022
@ghost
Copy link

ghost commented Feb 1, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

In #64251, I made a fix to catch decoding issues, but seems that the problem also occurs when printing those characters. On quick search reveals this problem and proposals to fix them, but the simplest thing to do in our situation would be to just return empty string if such errors occur. So I converted the decode_string method to decode_and_print which will catch the printing errors as well.

Fixes: #64575

Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak kunalspathak merged commit 3cbef97 into dotnet:main Feb 1, 2022
@BruceForstall
Copy link
Contributor

I wonder if maybe it should return something like <unicode conversion error>, but maybe it doesn't matter.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SuperPMI collect of benchmarks fails with "UnicodeEncodeError: 'charmap' codec can't encode character '\ufffd' in position 670361"

2 participants