Skip to content

Use global caching in JsonSerializerOptions #64646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eiriktsarpalis merged 10 commits into from
Feb 14, 2022
Merged

Use global caching in JsonSerializerOptions #64646

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
76c9069
Use caching in Reflection.Emit member accessors
eiriktsarpalis Feb 1, 2022
d1ffeaf
Refactor JsonSerializerOptions caching & use shared caching contexts
eiriktsarpalis Feb 4, 2022
fea5593
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…
eiriktsarpalis Feb 7, 2022
0e049e7
address feedback
eiriktsarpalis Feb 10, 2022
a2b8975
tweak cache eviction constants
eiriktsarpalis Feb 10, 2022
f9efaf9
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…
eiriktsarpalis Feb 11, 2022
801bf0b
minor refinements to cache eviction algorithm
eiriktsarpalis Feb 14, 2022
5b917e2
rename JsonSerializerOptions._context to _serializerContext
eiriktsarpalis Feb 14, 2022
761b2ad
ensure that the update handler clears the shared caching contexts
eiriktsarpalis Feb 14, 2022
3d9e9e2
fix remark
eiriktsarpalis Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tweak cache eviction constants
  • Loading branch information
@eiriktsarpalis
eiriktsarpalis committed Feb 10, 2022
commit a2b897563a5265ea4243fa42a689ddb5537fe02b
2 changes: 1 addition & 1 deletion ...t.Json/src/System/Text/Json/Serialization/Metadata/ReflectionEmitCachingMemberAccessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ internal sealed partial class ReflectionEmitCachingMemberAccessor : MemberAccess
{
private static readonly ReflectionEmitMemberAccessor s_sourceAccessor = new();
private static readonly Cache<(string id, Type declaringType, MemberInfo? member)> s_cache =
new(slidingExpiration: TimeSpan.FromSeconds(5), evictionInterval: TimeSpan.FromSeconds(1));
new(slidingExpiration: TimeSpan.FromMilliseconds(1000), evictionInterval: TimeSpan.FromMilliseconds(200));

public static void Clear() => s_cache.Clear();

Expand Down