[wasm][debugger] Fix some racy tests #64712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Tagging subscribers to this area: @thaystg Issue Detailsnull
|
This test is set up to pause on all exceptions. So, it has some code to hit `Debugger.resume` 100 times, hoping to skip all the non-user code exceptions. But this can sometimes not be enough, and you might have more exceptions which breaks rest of the test. Instead, we try to resume till we won't get paused for a period of 10secs. And after that, we can call the user code, and execute rest of the test. Fixes dotnet#62666 .
`DebuggerTests.MiscTests.DebugLazyLoadedAssemblyWithEmbeddedPdb` `DebuggerTests.BreakpointTests.BreakpointInAssemblyUsingTypeFromAnotherAssembly_BothDynamicallyLoaded` These tests load assemblies dynamically, and depend on breakpoints in those assemblies being resolved. But the tests don't wait for that to happen. So, they can some times fail when the managed method is invoked before the breakpoint being resolved. Fixes dotnet#62823 Fixes dotnet#62667
radical
force-pushed
the
fix-exception-test
branch
from
eba3073 to
58a7925
Compare
radical
changed the title
radical
requested review from
lewing,
marek-safar and
thaystg
and removed request for
marek-safar
thaystg
approved these changes
Feb 3, 2022
lewing
approved these changes
Feb 3, 2022
Member
lewing
left a comment
lewing
left a comment
There was a problem hiding this comment.
Looks good, should we add an explicit timeout option?
Member
Author
There is a per test timeout. Is that the one you meant? |
Member
Author
|
.. and I did test the case where the breakpoint is never hit, and the test fails with a timeout. |
Member
Author
|
Wasm (unrelated) test failures are because of #64769 . The (unrelated) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests that use late loaded assemblies
DebuggerTests.MiscTests.DebugLazyLoadedAssemblyWithEmbeddedPdbDebuggerTests.BreakpointTests.BreakpointInAssemblyUsingTypeFromAnotherAssembly_BothDynamicallyLoadedExceptionTestAllWithReloadFixes #62666
Fixes #62823
Fixes #62667