Improve metadata generation resiliency #64715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler avoids dealing with things that don't resolve and we have handling for those in place to turn them into runtime exceptions. We hit a situation when it doesn't kick in: * We're working with a nested type that is fine, but it's owning type is not (it implements an interface that doesn't resolve). * The protections within the compiler kick in and avoid bringing the containing type into compilation. * Once we're done compiling, we need to generate native reflection metadata for the nested type and that requires generating native metadata for the owning type. We don't have protections there because it's too late to do anything about it. I'm adding code that skips problematic parts of the metadata. This is a slight compat problem because doing a `typeof(NestedType).DeclaringType` would throw on JIT-based CoreCLR, but will now succeed on NativeAOT-based CoreCLR. The returned type will have an empty interface list. The compat in this corner case probably doesn't matter much.
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler avoids dealing with things that don't resolve and we have handling for those in place to turn them into runtime exceptions.
We hit a situation when it doesn't kick in:
I'm adding code that skips problematic parts of the metadata.
This is a slight compat problem because doing a
typeof(NestedType).DeclaringTypewould throw on JIT-based CoreCLR, but will now succeed on NativeAOT-based CoreCLR. The returned type will have an empty interface list. The compat in this corner case probably doesn't matter much.