Skip to content

Add support for Windows IO completions to the portable thread pool #64834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kouvel merged 13 commits into from
Mar 4, 2022
Merged

Add support for Windows IO completions to the portable thread pool #64834

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
057ceed
Add support for Windows IO completions to the portable thread pool
Jan 8, 2022
37a66e0
Translate NtStatus codes to system error codes, fix some other failur…
Feb 7, 2022
3233ae0
Fix wasm build
Feb 7, 2022
7c0d7d5
Try to fix a time-sensitive test, enable some tests on Mono based on …
Feb 7, 2022
759e11a
Enable some more tests on Mono based on #34582
Feb 7, 2022
12f40a2
Miscellaneous fixes
Feb 8, 2022
0a2dc42
Temporarily enable libraries tests against Mono for this PR
Feb 8, 2022
64cca54
Try to fix a time-sensitive test that is occasionally failing
Feb 11, 2022
251de07
Note SOS usage of a variable
Feb 12, 2022
165842a
Address feedback
Feb 17, 2022
81f18f0
Revert "Temporarily enable libraries tests against Mono for this PR"
Feb 27, 2022
14893de
Fix build after rebase
Feb 27, 2022
a310f12
Add checks for some DOTNET vars from Net.Sockets and implement inlini…
Feb 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enable some more tests on Mono based on #34582
  • Loading branch information
Koundinya Veluri committed Mar 3, 2022
commit 759e11a9a393c2225a25df301ee0505a91dda605
2 changes: 1 addition & 1 deletion src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ private static bool GetLinqExpressionsBuiltWithIsInterpretingOnly()
// Drawing is not supported on non windows platforms in .NET 7.0+.
public static bool IsDrawingSupported => IsWindows && IsNotWindowsNanoServer && IsNotWindowsServerCore;

public static bool IsAsyncFileIOSupported => !IsBrowser && !(IsWindows && IsMonoRuntime); // https://github.com/dotnet/runtime/issues/34582
public static bool IsAsyncFileIOSupported => !IsBrowser;

public static bool IsLineNumbersSupported => !IsNativeAot;

Expand Down
3 changes: 0 additions & 3 deletions ...raries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ private void SetSecret(string id, string key, string value)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void AddUserSecrets_FindsAssemblyAttribute()
{
Expand All @@ -68,7 +67,6 @@ public void AddUserSecrets_FindsAssemblyAttribute()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void AddUserSecrets_FindsAssemblyAttributeFromType()
{
Expand Down Expand Up @@ -123,7 +121,6 @@ public void AddUserSecrets_DoesThrowsIfNotOptionalAndSecretDoesNotExist()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void AddUserSecrets_With_SecretsId_Passed_Explicitly()
{
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ArrayTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public class ArrayTests : IDisposable
";

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void DifferentConfigSources_Merged_KeysAreSorted()
{
Expand Down Expand Up @@ -77,7 +76,6 @@ public void DifferentConfigSources_Merged_KeysAreSorted()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void DifferentConfigSources_Merged_WithOverwrites()
{
Expand Down
12 changes: 0 additions & 12 deletions src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ public void MissingFileDoesNotIncludesAbsolutePathIfWithNoPhysicalPath()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public void LoadAndCombineKeyValuePairsFromDifferentConfigurationProviders()
{
WriteTestFiles();
Expand Down Expand Up @@ -247,7 +246,6 @@ public void LoadAndCombineKeyValuePairsFromDifferentConfigurationProviders()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public void LoadAndCombineKeyValuePairsFromDifferentConfigurationProvidersWithAbsolutePath()
{
WriteTestFiles();
Expand Down Expand Up @@ -288,7 +286,6 @@ public void LoadAndCombineKeyValuePairsFromDifferentConfigurationProvidersWithAb
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public void CanOverrideValuesWithNewConfigurationProvider()
{
WriteTestFiles();
Expand Down Expand Up @@ -361,7 +358,6 @@ public IConfigurationProvider Build(IConfigurationBuilder builder)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void OnLoadErrorWillBeCalledOnJsonParseError()
{
Expand Down Expand Up @@ -391,7 +387,6 @@ public void OnLoadErrorWillBeCalledOnJsonParseError()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public void OnLoadErrorWillBeCalledOnXmlParseError()
{
_fileSystem.WriteFile("error.xml", @"gobblygook");
Expand Down Expand Up @@ -419,7 +414,6 @@ public void OnLoadErrorWillBeCalledOnXmlParseError()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public void OnLoadErrorWillBeCalledOnIniLoadError()
{
_fileSystem.WriteFile("error.ini", @"IniKey1=IniValue1
Expand Down Expand Up @@ -448,7 +442,6 @@ public void OnLoadErrorWillBeCalledOnIniLoadError()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public void OnLoadErrorCanIgnoreErrors()
{
_fileSystem.WriteFile("error.json", @"{""JsonKey1"": ");
Expand Down Expand Up @@ -821,7 +814,6 @@ await WaitForChange(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50866", TestPlatforms.Android)]
public void LoadIncorrectJsonFile_ThrowException()
{
Expand All @@ -839,7 +831,6 @@ public void LoadIncorrectJsonFile_ThrowException()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public void SetBasePathCalledMultipleTimesForEachSourceLastOneWins()
{
var builder = new ConfigurationBuilder();
Expand Down Expand Up @@ -873,7 +864,6 @@ public void SetBasePathCalledMultipleTimesForEachSourceLastOneWins()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void GetDefaultBasePathForSources()
{
Expand Down Expand Up @@ -904,7 +894,6 @@ public void GetDefaultBasePathForSources()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "System.IO.FileSystem.Watcher is not supported on Browser/iOS/tvOS")]
public void CanEnumerateProviders()
{
Expand Down Expand Up @@ -952,7 +941,6 @@ await WaitForChange(
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public void BindingDoesNotThrowIfReloadedDuringBinding()
{
WriteTestFiles();
Expand Down
Loading