[Mono] Fix potential crash when handling image load event. #64908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
approved these changes
Feb 7, 2022
Member
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1807421663 |
Contributor
|
@lateralusX an error occurred while backporting to release/6.0, please check the run log for details! Error: @lateralusX is not a repo collaborator, backporting is not allowed. |
Member
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1807445559 |
Member
|
@lateralusX for the backport bot to work you need to go to https://github.com/orgs/microsoft/people?query=lateralusX and switch your team membership visibility to Public. |
This was referenced Feb 8, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running dotnet-trace against MonoVM running on Android and including the loader (image/assembly load/unload) events from Microsoft-Windows-DotNETRuntime caused a runtime crash when handling Mono.Android.dll assembly. Happens since that assembly didn't include a debug directory entry in release build, that in turn left a field on the stack uninitialized, causing potential crash depending on current stack content.
Fix makes sure the struct always gets initialized and that we explicitly set that field (module_il_pdb_path) to an empty string if assembly doesn't include a debug directory entry.
Fixes:
#64458
dotnet/android#6700