-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Send CA names on Linux and OSX #65195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rzikm
merged 15 commits into
dotnet:main
from
rzikm:55802-Add-ability-to-send-SslCertificateTrust-in-TLS-handshake-on-Linux-and-macOS
Feb 24, 2022
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a0d76d8
Send CA names on Linux
rzikm 23cfd08
Optimize setting certname list in OpenSSL
rzikm 717e866
First shot at OSX implementation
rzikm 7247db0
Fix tests on OSX
rzikm 09e01eb
Optimize setting certificates on OSX
rzikm 9ee8520
Improve message in PNSE
rzikm 17b573c
Fix compilation
rzikm 5cad62d
Use only CA certificates in test
rzikm 33fda73
Remove unwanted formatting changes
rzikm 6432d87
Skip non-CA certificates
rzikm 27fd404
Fix crash on OSX
rzikm e064a9d
Disable new tests on Windows
rzikm 15cc494
Revert "Skip non-CA certificates"
rzikm fbba399
Fix tests on Ubuntu 18.04
rzikm e40e1b0
Change cert name
rzikm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use only CA certificates in test
- Loading branch information
commit 5cad62d00ba897bd5de528284bb65af6aa1b47fc
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can use nameof(SslStream_SendCertificateTrust_CertificateCollection) -> using test names sometimes helps with debugging if tests are running in parallel.