Skip to content

JIT: Unroll Equals and StartsWith for constant strings and spans. [0..32] chars #65288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 38 commits into from
Mar 2, 2022
Merged

JIT: Unroll Equals and StartsWith for constant strings and spans. [0..32] chars #65288

Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
41a57d2
Unroll & vectorize String.Equals
EgorBo Feb 13, 2022
e7106d6
fix bug
EgorBo Feb 13, 2022
2985162
StartsWith, clean up
EgorBo Feb 14, 2022
4047ce5
Update importer.cpp
EgorBo Feb 14, 2022
7d88960
fix build errors
EgorBo Feb 14, 2022
486d384
formatting
EgorBo Feb 14, 2022
8d4bc7e
Add Spans, move everything to a separate file
EgorBo Feb 16, 2022
87fa3bf
Clean up, more comments
EgorBo Feb 16, 2022
8dc111b
fix typos, clean up
EgorBo Feb 16, 2022
c9658dc
Address feedback
EgorBo Feb 16, 2022
6f29646
Use IND for simd loads
EgorBo Feb 16, 2022
210c4f1
Merge branch 'main' of https://github.com/dotnet/runtime into jit-unr…
EgorBo Feb 16, 2022
c8826ee
Address feedback
EgorBo Feb 16, 2022
9c8033f
fix assert
EgorBo Feb 16, 2022
08ab8e2
formatting
EgorBo Feb 16, 2022
4cf0b96
Merge branch 'main' of https://github.com/dotnet/runtime into jit-unr…
EgorBo Feb 17, 2022
39b6151
How is MemoryExtensions.AsSpan(string,int) also gets recognized as [I…
EgorBo Feb 18, 2022
52c54a5
fix AsSpan and op_Implicit intrinsics
EgorBo Feb 18, 2022
f4bac1f
Merge branch 'main' of https://github.com/dotnet/runtime into jit-unr…
EgorBo Feb 18, 2022
de2faa9
Fix r2r assert
EgorBo Feb 18, 2022
da4135f
Merge branch 'main' of https://github.com/dotnet/runtime into jit-unr…
EgorBo Feb 19, 2022
6252775
minor clean up
EgorBo Feb 20, 2022
f35da70
Merge branch 'main' of https://github.com/dotnet/runtime into jit-unr…
EgorBo Feb 21, 2022
a45c705
Fix bug with s.StartsWith("", Ordinal) - it should be optimized to CO…
EgorBo Feb 22, 2022
40550e9
Clean up
EgorBo Feb 22, 2022
a524530
Update UnrollEqualsStartsWIth.cs
EgorBo Feb 22, 2022
eadc97e
Merge branch 'main' of https://github.com/dotnet/runtime into jit-unr…
EgorBo Feb 26, 2022
411af86
Update src/coreclr/jit/importer_vectorization.cpp
EgorBo Feb 26, 2022
6581fa8
Merge branch 'jit-unroll-equals' of https://github.com/EgorBo/runtime…
EgorBo Feb 26, 2022
aa48801
Address feedback
EgorBo Feb 26, 2022
abaf73a
Address feedback
EgorBo Feb 26, 2022
f42ae58
Address feedback
EgorBo Feb 26, 2022
9c64132
Apply suggestions from code review
EgorBo Feb 26, 2022
afb814d
Update src/coreclr/jit/importer_vectorization.cpp
EgorBo Feb 26, 2022
345246c
fix cast type
EgorBo Feb 26, 2022
ab5af13
Merge branch 'main' of https://github.com/dotnet/runtime into jit-unr…
EgorBo Mar 1, 2022
d42a006
Remove redundant cast
EgorBo Mar 1, 2022
971629c
Merge branch 'main' of https://github.com/dotnet/runtime into jit-unr…
EgorBo Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix assert
  • Loading branch information
@EgorBo
EgorBo committed Feb 16, 2022
commit 9c8033f0c436fa0d7c3301b2f6fac61c876c6e8f
2 changes: 1 addition & 1 deletion src/coreclr/jit/importer_vectorization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ GenTreeStrCon* Compiler::impGetStrConFromSpan(GenTree* span)
if ((ni == NI_System_MemoryExtensions_AsSpan) || (ni == NI_System_String_op_Implicit))
{
// To make sure only single-arg methods are marked as [Intrinsic]
assert(argCall->fgArgInfo->ArgCount() == 1);
assert(argCall->gtCallArgs->GetNext() == nullptr);

if (argCall->gtCallArgs->GetNode()->OperIs(GT_CNS_STR))
{
Expand Down