Skip to content

Fix issues related to JsonSerializerOptions mutation and caching. #65863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eiriktsarpalis merged 3 commits into from
Mar 4, 2022
Merged

Fix issues related to JsonSerializerOptions mutation and caching. #65863

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
854d712
Fix issues related to JsonSerializerOptions mutation and caching.
eiriktsarpalis Feb 23, 2022
71a53a1
fix test style
eiriktsarpalis Feb 24, 2022
40cf07a
fix linker warning
eiriktsarpalis Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test style
  • Loading branch information
@eiriktsarpalis
eiriktsarpalis committed Mar 1, 2022
commit 71a53a12d88a79b43680a99d82ce7080ed9270f8
4 changes: 2 additions & 2 deletions src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,8 +532,8 @@ public static void JsonSerializerOptions_Default_IsReadOnly()
var optionsSingleton = JsonSerializerOptions.Default;
Assert.Throws<InvalidOperationException>(() => optionsSingleton.IncludeFields = true);
Assert.Throws<InvalidOperationException>(() => optionsSingleton.Converters.Add(new JsonStringEnumConverter()));
Assert.Throws<InvalidOperationException>(() => JsonSerializerOptions.Default.AddContext<JsonContext>());
Assert.Throws<InvalidOperationException>(() => new JsonContext(JsonSerializerOptions.Default));
Assert.Throws<InvalidOperationException>(() => optionsSingleton.AddContext<JsonContext>());
Assert.Throws<InvalidOperationException>(() => new JsonContext(optionsSingleton));
}

[Fact]
Expand Down