Skip to content

[Mono] Intrinsify Convert* for Vector{64, 128} on ARM64 #65946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fanyang-mono merged 8 commits into from
Mar 7, 2022
Merged

[Mono] Intrinsify Convert* for Vector{64, 128} on ARM64 #65946

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f338078
Intrinsify Convert*
fanyang-mono Feb 28, 2022
39d1713
Test - comment out my change
fanyang-mono Mar 2, 2022
90d09d7
Enable ConvertToDouble
fanyang-mono Mar 2, 2022
c7aee13
Enable ConvertToInt32 and ConvertToUInt32
fanyang-mono Mar 2, 2022
ce73146
Enable ConvertToInt64 and ConvertToUInt64
fanyang-mono Mar 2, 2022
d6f863b
Disable ConvertToInt64 and ConvertToUInt64, but enable ConvertToSingle
fanyang-mono Mar 3, 2022
a99154e
Remove the support for ConvertToInt64, ConvertToUInt64 and ConvertToS…
fanyang-mono Mar 3, 2022
9b3250c
Merge branch 'main' into arm64_convert
fanyang-mono Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable ConvertToInt64 and ConvertToUInt64, but enable ConvertToSingle
  • Loading branch information
@fanyang-mono
fanyang-mono committed Mar 3, 2022
commit d6f863b90d554f19ef90ebb9d041d1e9574f747f
46 changes: 23 additions & 23 deletions src/mono/mono/mini/simd-intrinsics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,10 +588,10 @@ static guint16 sri_vector_methods [] = {
SN_ConditionalSelect,
SN_ConvertToDouble,
SN_ConvertToInt32,
SN_ConvertToInt64,
// SN_ConvertToSingle,
// SN_ConvertToInt64,
SN_ConvertToSingle,
SN_ConvertToUInt32,
SN_ConvertToUInt64,
// SN_ConvertToUInt64,
SN_Create,
SN_CreateScalar,
SN_CreateScalarUnsafe,
Expand Down Expand Up @@ -807,33 +807,33 @@ emit_sri_vector (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSignature *fsi
return NULL;
#endif
}
case SN_ConvertToInt64:
case SN_ConvertToUInt64: {
#ifdef TARGET_ARM64
if (arg0_type != MONO_TYPE_R8)
return NULL;
MonoClass *arg_class = mono_class_from_mono_type_internal (fsig->params [0]);
int size = mono_class_value_size (arg_class, NULL);
int op = -1;
if (id == SN_ConvertToInt64)
op = size == 8 ? OP_ARM64_FCVTZS_SCALAR : OP_ARM64_FCVTZS;
else
op = size == 8 ? OP_ARM64_FCVTZU_SCALAR : OP_ARM64_FCVTZU;
return emit_simd_ins_for_sig (cfg, klass, op, -1, arg0_type, fsig, args);
#else
return NULL;
#endif
}
// case SN_ConvertToSingle: {
// case SN_ConvertToInt64:
// case SN_ConvertToUInt64: {
// #ifdef TARGET_ARM64
// if ((arg0_type != MONO_TYPE_I4) && (arg0_type != MONO_TYPE_U4))
// if (arg0_type != MONO_TYPE_R8)
// return NULL;
// int op = arg0_type == MONO_TYPE_I4 ? OP_ARM64_SCVTF : OP_ARM64_UCVTF;
// MonoClass *arg_class = mono_class_from_mono_type_internal (fsig->params [0]);
// int size = mono_class_value_size (arg_class, NULL);
// int op = -1;
// if (id == SN_ConvertToInt64)
// op = size == 8 ? OP_ARM64_FCVTZS_SCALAR : OP_ARM64_FCVTZS;
// else
// op = size == 8 ? OP_ARM64_FCVTZU_SCALAR : OP_ARM64_FCVTZU;
// return emit_simd_ins_for_sig (cfg, klass, op, -1, arg0_type, fsig, args);
// #else
// return NULL;
// #endif
// }
case SN_ConvertToSingle: {
#ifdef TARGET_ARM64
if ((arg0_type != MONO_TYPE_I4) && (arg0_type != MONO_TYPE_U4))
return NULL;
int op = arg0_type == MONO_TYPE_I4 ? OP_ARM64_SCVTF : OP_ARM64_UCVTF;
return emit_simd_ins_for_sig (cfg, klass, op, -1, arg0_type, fsig, args);
#else
return NULL;
#endif
}
case SN_Create: {
MonoType *etype = get_vector_t_elem_type (fsig->ret);
if (fsig->param_count == 1 && mono_metadata_type_equal (fsig->params [0], etype))
Expand Down