Skip to content

Conversation

@joperezr
Copy link
Member

@joperezr joperezr commented Mar 2, 2022

#64279 introduced an issue with the marshalling of BerVal which is causing System.DirectoryServces.Protocols to fail to authenticate against an LDAP server when using credentials due to an encoding issue caused by an extra indirection. With the help of @jkoritzinsky we found that this was because we had an extra indirection on the PInvokes where we passed in this struct.

This PR fixes that issue and I have validated that our DirectoryServicesProtocols manual tests all pass after this change.

cc: @lscorcia since you were seeing this issue locally. After merging this you should be able to run your scenario tests again.

@joperezr joperezr requested a review from jkoritzinsky March 2, 2022 23:32
@ghost
Copy link

ghost commented Mar 2, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Mar 2, 2022

Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014
See info in area-owners.md if you want to be subscribed.

Issue Details

#64279 introduced an issue with the marshalling of BerVal which is causing System.DirectoryServces.Protocols to fail to authenticate against an LDAP server when using credentials due to an encoding issue caused by an extra indirection. With the help of @jkoritzinsky we found that this was because we had an extra indirection on the PInvokes where we passed in this struct.

This PR fixes that issue and I have validated that our DirectoryServicesProtocols manual tests all pass after this change.

cc: @lscorcia since you were seeing this issue locally. After merging this you should be able to run your scenario tests again.

Author: joperezr
Assignees: joperezr
Labels:

area-System.DirectoryServices

Milestone: -

@joperezr joperezr merged commit 0e6a73a into dotnet:main Mar 3, 2022
@joperezr joperezr deleted the FixDirectoryServicesProtocols branch March 3, 2022 04:13
@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants