Fix marshalling issue with BerVal #66119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#64279 introduced an issue with the marshalling of BerVal which is causing System.DirectoryServces.Protocols to fail to authenticate against an LDAP server when using credentials due to an encoding issue caused by an extra indirection. With the help of @jkoritzinsky we found that this was because we had an extra indirection on the PInvokes where we passed in this struct.
This PR fixes that issue and I have validated that our DirectoryServicesProtocols manual tests all pass after this change.
cc: @lscorcia since you were seeing this issue locally. After merging this you should be able to run your scenario tests again.