Skip to content

Do not generate TYP_STRUCT LCL_FLD nodes #66251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunalspathak merged 4 commits into from
Mar 30, 2022
Merged

Do not generate TYP_STRUCT LCL_FLD nodes #66251

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83a3f3c
Do not create TYP_STRUCT LCL_FLD
SingleAccretion Mar 5, 2022
202fc54
Fix regressions
SingleAccretion Mar 5, 2022
acf22a0
More fixes for regressions
SingleAccretion Mar 7, 2022
dba8765
Add a comment
SingleAccretion Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix regressions 
This is also a correctness fix. Missing adding zero-offset field sequences is fatal.
  • Loading branch information
@SingleAccretion
SingleAccretion committed Mar 9, 2022
commit 202fc5430d74767c2f0c49ca8ac3741cd7d72c70
7 changes: 7 additions & 0 deletions src/coreclr/jit/gentree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15641,8 +15641,15 @@ bool GenTree::IsLocalAddrExpr(Compiler* comp,
{
assert(!comp->compRationalIRForm);
GenTree* addrArg = AsOp()->gtOp1;

if (addrArg->IsLocal()) // Note that this covers "GT_LCL_FLD."
{
FieldSeqNode* zeroOffsetFieldSeq = nullptr;
if (comp->GetZeroOffsetFieldMap()->Lookup(this, &zeroOffsetFieldSeq))
{
*pFldSeq = comp->GetFieldSeqStore()->Append(zeroOffsetFieldSeq, *pFldSeq);
}

*pLclVarTree = addrArg->AsLclVarCommon();
if (addrArg->OperGet() == GT_LCL_FLD)
{
Expand Down