Add timestamp to some superpmi.py output #66437
Conversation
This should help determine where time is being spent in long-running tasks such as PMI or crossgen2 collections in the CI system.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis should help determine where time is being spent in long-running
|
|
@kunalspathak PTAL |
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
I thought we would have a timeprefix before the line that superpmi.exe prints, to understand if particular .dll is taking time or not? In latest runs, we see that crossgen2 win-arm64 timed out , but we need to see and compare which .dll(s) are more time consuming compared to win-x64 counter parts. The time prefix at beginning/end would still help, but not sure how useful it would be.
| return | ||
|
|
||
| logging.log(log_level, "============== Contents of %s", filepath) | ||
| logging.log(log_level, "%s============== Contents of %s", get_time_prefix(), filepath) |
There was a problem hiding this comment.
Don't think printing time here is of any use. The real time prefix needs to happen at the point where the contents in the filepath were created.
There was a problem hiding this comment.
It's true it might not be what we might want to see, but it does provide at least some information.
ghost
added
needs-author-action
|
The main potential benefit here is the line that prints out status, e.g., |
|
Sure, lets give it a try and see if it helps. |
2 participants
This should help determine where time is being spent in long-running
tasks such as PMI or crossgen2 collections in the CI system.