Skip to content

Removed JIT (uint) cast workaround to elide bound-checks in CoreLib #67448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 13 commits into from
Jul 12, 2022
Merged

Removed JIT (uint) cast workaround to elide bound-checks in CoreLib #67448

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cf4ccd4
Removed (uint) cast workaround in CoreLib, annotated missing places w…
gfoidl Apr 1, 2022
af9b2d6
Fixed the bug I introduced in TimeSpanParse.TimeSpanTokenizer
gfoidl Apr 1, 2022
19b8e00
Use uint-cast on both sided for clarity
gfoidl Apr 2, 2022
33cd7a1
Added missing namespace (oops)
gfoidl Apr 2, 2022
20842e6
Use uint-division in BitHelper as the JIT can produce more efficient …
gfoidl Apr 4, 2022
da31c0b
Don't have struct local in ValueStringBuilder due to hitting JIT opti…
gfoidl Apr 4, 2022
7e816a5
BitHelper with uint division and without Math.DivRem for even better …
gfoidl Apr 4, 2022
d9f4e01
BitHelper needs local Span due to regression in jit-diff otherwise
gfoidl Apr 4, 2022
034dd89
Fixed dumb copy & paste failure in BitHelper.IsMarked
gfoidl Apr 5, 2022
76d6d2a
Merge branch 'main' into remove-bound-check-hack
gfoidl May 23, 2022
186fb58
Added Debug.Asserts to BitHelper's method that take bitPosition
gfoidl Jul 11, 2022
6afa6c2
BitHelper: comment for workaround to tracking issue
gfoidl Jul 12, 2022
26f459f
Update src/libraries/System.Private.CoreLib/src/System/Collections/Ge…
gfoidl Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't have struct local in ValueStringBuilder due to hitting JIT opti… 
…mization limits

Cf. #67448 (comment)
  • Loading branch information
@gfoidl
gfoidl committed Apr 4, 2022
commit da31c0b334046205da7aa776dceaecc2c82e56ba
10 changes: 4 additions & 6 deletions src/libraries/Common/src/System/Text/ValueStringBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,9 @@ public void Insert(int index, string? s)
public void Append(char c)
{
int pos = _pos;
Span<char> chars = _chars;
if ((uint)pos < (uint)chars.Length)
if ((uint)pos < (uint)_chars.Length)
{
chars[pos] = c;
_chars[pos] = c;
_pos = pos + 1;
}
else
Expand All @@ -191,10 +190,9 @@ public void Append(string? s)
}

int pos = _pos;
Span<char> chars = _chars;
if (s.Length == 1 && (uint)pos < (uint)chars.Length) // very common case, e.g. appending strings from NumberFormatInfo like separators, percent symbols, etc.
if (s.Length == 1 && (uint)pos < (uint)_chars.Length) // very common case, e.g. appending strings from NumberFormatInfo like separators, percent symbols, etc.
{
chars[pos] = s[0];
_chars[pos] = s[0];
_pos = pos + 1;
}
else
Expand Down