Skip to content

Asynchronous opening of QuicStreams #67859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzikm merged 25 commits into from
Apr 27, 2022
Merged

Asynchronous opening of QuicStreams #67859

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
8f7c210
Early draft of Open(Uni|Bidi)rectionalStreamAsync
rzikm Apr 11, 2022
3c2b1f7
Improve exception handling
rzikm Apr 11, 2022
ed05be7
Remove non-Async versions
rzikm Apr 11, 2022
08420ff
fixup! Improve exception handling
rzikm Apr 11, 2022
ac3bfbf
Add tests
rzikm Apr 11, 2022
43acea1
fixup! Remove non-Async versions
rzikm Apr 11, 2022
fa9fdbf
handle connection abort
rzikm Apr 11, 2022
c7bdf87
Merge remote-tracking branch 'upstream/main' into 67302-quic-stream-o…
rzikm Apr 11, 2022
7744b97
Minor change
rzikm Apr 12, 2022
de17440
Fix build
rzikm Apr 12, 2022
5abe872
Code review feedback
rzikm Apr 13, 2022
5143c42
Remove WaitForAvailable* methods
rzikm Apr 13, 2022
836a501
fixup! Remove WaitForAvailable* methods
rzikm Apr 13, 2022
52f7ee2
Remove CreateOuboundAsync static method
rzikm Apr 19, 2022
5fab97e
Remove StartStatus
rzikm Apr 19, 2022
95af94f
Code review changes
rzikm Apr 21, 2022
b51bad8
More code review changes
rzikm Apr 21, 2022
bbf1d65
Fix build
rzikm Apr 21, 2022
79ce72b
Fix data race on locally closing the connection
rzikm Apr 22, 2022
346d025
Code review feedback
rzikm Apr 25, 2022
2c299dc
Remove PInvoke for reporting telemetry
rzikm Apr 25, 2022
253d09e
Minor fixes
rzikm Apr 26, 2022
4b09357
fixup! Minor fixes
rzikm Apr 26, 2022
91e1d33
Regenerate ref source
rzikm Apr 26, 2022
9ce1f07
Fix exception type in test
rzikm Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code review changes
  • Loading branch information
@rzikm
rzikm committed Apr 21, 2022
commit 95af94f01949b9799329688add3b90aaca7dba96
12 changes: 10 additions & 2 deletions src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,9 +1124,17 @@ private static uint HandleEventStartComplete(State state, ref StreamEvent evt)
// - StreamLimitReached - only if QUIC_STREAM_START_FLAG_FAIL_BLOCKED was specified (not in our case).
//
// We disregard duplicate StreamStart calls
if (status == MsQuicStatusCodes.Aborted)
{
state.StartCompletionSource.SetException(
ExceptionDispatchInfo.SetCurrentStackTrace(GetConnectionAbortedException(state)));
}
else
{
state.StartCompletionSource.SetException(
ExceptionDispatchInfo.SetCurrentStackTrace(new QuicException($"StreamStart finished with status{MsQuicStatusCodes.GetError(status)}")));
}
Debug.Assert(status == MsQuicStatusCodes.Aborted || status == MsQuicStatusCodes.InvalidState);
state.StartCompletionSource.SetException(
ExceptionDispatchInfo.SetCurrentStackTrace(GetConnectionAbortedException(state)));
}
else if ((evt.Data.StartComplete.PeerAccepted & 1) != 0)
{
Expand Down