Use HAVE* in pal_io.c to detect library where makedev is available. D…

…o explicit casts to prevent build failures in wasm.

GetDeviceFiles p/invoke now returns int in case of error.

src/libraries/Common/src/Interop/Unix/System.Native/Interop.DeviceFiles.cs

@@ -23,6 +23,6 @@ internal static int CreateCharacterDevice(string pathName, uint mode, uint major
         private static partial int MkNod(string pathName, uint mode, uint major, uint minor);
 
         [LibraryImport(Libraries.SystemNative, EntryPoint = "SystemNative_GetDeviceIdentifiers", SetLastError = true)]
-        internal static partial void GetDeviceIdentifiers(ulong dev, out uint major, out uint minor);
+        internal static unsafe partial int GetDeviceIdentifiers(ulong dev, uint* majorNumber, uint* minorNumber);
     }
 }

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarWriter.Unix.cs

@@ -43,7 +43,13 @@ partial void ReadFileFromDiskAndWriteToArchiveStreamAsEntry(string fullPath, str
 
             if ((entryType is TarEntryType.BlockDevice or TarEntryType.CharacterDevice) && status.Dev > 0)
             {
-                Interop.Sys.GetDeviceIdentifiers((ulong)status.Dev, out uint major, out uint minor);
+                uint major;
+                uint minor;
+                unsafe
+                {
+                    Interop.CheckIo(Interop.Sys.GetDeviceIdentifiers((ulong)status.Dev, &major, &minor));
+                }
+
                 entry._header._devMajor = (int)major;
                 entry._header._devMinor = (int)minor;
             }

src/native/libs/Common/pal_config.h.in

@@ -135,6 +135,8 @@
 #cmakedefine01 HAVE_MALLOC_USABLE_SIZE
 #cmakedefine01 HAVE_MALLOC_USABLE_SIZE_NP
 #cmakedefine01 HAVE_POSIX_MEMALIGN
+#cmakedefine01 HAVE_MAKEDEV_FILEH
+#cmakedefine01 HAVE_MAKEDEV_SYSMACROSH
 
 // Mac OS X has stat64, but it is deprecated since plain stat now
 // provides the same 64-bit aware struct when targeting OS X > 10.5

src/native/libs/System.Native/pal_io.c

@@ -22,7 +22,7 @@
 #include <sys/file.h>
 #include <sys/ioctl.h>
 #include <sys/socket.h>
-#if !defined(TARGET_OSX) && !defined(TARGET_FREEBSD)
+#if !HAVE_MAKEDEV_FILEH && HAVE_MAKEDEV_SYSMACROSH
 #include <sys/sysmacros.h>
 #endif
 #include <sys/uio.h>
@@ -770,21 +770,17 @@ int32_t SystemNative_SymLink(const char* target, const char* linkPath)
     return result;
 }
 
-void SystemNative_GetDeviceIdentifiers(uint64_t dev, uint32_t* major, uint32_t* minor)
+int32_t SystemNative_GetDeviceIdentifiers(uint64_t dev, uint32_t* majorNumber, uint32_t* minorNumber)
 {
     dev_t castedDev = (dev_t)dev;
-    *major = major(castedDev);
-    *minor = minor(castedDev);
+    *majorNumber = (uint32_t)major(castedDev);
+    *minorNumber = (uint32_t)minor(castedDev);
+    return ConvertErrorPlatformToPal(errno);
 }
 
 int32_t SystemNative_MkNod(const char* pathName, uint32_t mode, uint32_t major, uint32_t minor)
 {
-#if defined(TARGET_WASM)
-    unsigned long long
-#else
-    dev_t
-#endif
-    dev = makedev(major, minor);
+    dev_t dev = (dev_t)makedev(major, minor);
 
     if (errno > 0)
     {

src/native/libs/System.Native/pal_io.h

@@ -543,8 +543,9 @@ PALEXPORT int32_t SystemNative_SymLink(const char* target, const char* linkPath)
 
 /**
  * Given a device ID, extracts the major and minor and components and returns them.
+ * Return 0 on success; otherwise, returns -1 and errno is set.
  */
-PALEXPORT void SystemNative_GetDeviceIdentifiers(uint64_t dev, uint32_t* major, uint32_t* minor);
+PALEXPORT int32_t SystemNative_GetDeviceIdentifiers(uint64_t dev, uint32_t* majorNumber, uint32_t* minorNumber);
 
 /**
  * Creates a special or ordinary file.

src/native/libs/configure.cmake

@@ -1122,6 +1122,20 @@ check_c_source_compiles(
     "
     HAVE_BUILTIN_MUL_OVERFLOW)
 
+check_symbol_exists(
+    makedev
+    sys/file.h
+    HAVE_MAKEDEV_FILEH)
+
+check_symbol_exists(
+    makedev
+    sys/sysmacros.h
+    HAVE_MAKEDEV_SYSMACROSH)
+
+if (NOT HAVE_MAKEDEV_FILEH AND NOT HAVE_MAKEDEV_SYSMACROSH)
+  message(FATAL_ERROR "Cannot find the makedev function on this platform.")
+endif()
+
 configure_file(
     ${CMAKE_CURRENT_SOURCE_DIR}/Common/pal_config.h.in
     ${CMAKE_CURRENT_BINARY_DIR}/Common/pal_config.h)