Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
c6edafb
MsQuicApi adjusted
ManickaP Apr 8, 2022
ea31c49
QuicParamHelper adjusted
ManickaP Apr 8, 2022
8d41cbb
MsQuicConfiguration adjusted
ManickaP Apr 8, 2022
55dc554
Added MsQuicException
ManickaP Apr 9, 2022
259545e
MsQuicConnection adjusted
ManickaP Apr 9, 2022
d0fb04e
MsQuicListener adjusted
ManickaP Apr 9, 2022
b3d76cf
MsQuicStream adjusted
ManickaP Apr 9, 2022
103cd1f
It compiles!
ManickaP Apr 9, 2022
08b5b47
Some test fixes
ManickaP Apr 10, 2022
7794b58
Fixed stream read event handling
ManickaP Apr 20, 2022
46a7401
Re-enabled IPv6 tests
ManickaP Apr 20, 2022
182a8f0
latest greatest
ManickaP Apr 20, 2022
2b0172c
Update src/libraries/System.Net.Quic/src/System/Net/Quic/Implementati…
ManickaP Apr 20, 2022
3162353
MsQuic interop enum names
ManickaP Apr 21, 2022
88a5d89
Merge branch 'main' into mapichov/quic_interop
ManickaP Apr 21, 2022
166fa96
3rd Party notice, version check
ManickaP Apr 22, 2022
de307c3
SafeHandleType
ManickaP Apr 22, 2022
c955a4f
Replaced AlpnHelpers with MsQuicBuffers generic QUIC_BUFFER* helper
ManickaP Apr 25, 2022
6186a23
Sealed exception class
ManickaP Apr 25, 2022
f64b1d1
Feedback MsQuicBuffers
ManickaP Apr 25, 2022
43c6417
NativeMemory use
ManickaP Apr 25, 2022
059c3d4
Merge branch 'main' into mapichov/quic_interop
ManickaP May 3, 2022
cd3b00d
Newest msquic interop
ManickaP May 3, 2022
c6e0d6c
Buffers feedback
ManickaP May 3, 2022
de15868
Remove MemoryHandle pooling
ManickaP May 4, 2022
a73cfa8
Buffers feedback
ManickaP May 4, 2022
d52fcdb
Logging feedback
ManickaP May 4, 2022
cf2377c
Merge branch 'main' into mapichov/quic_interop
ManickaP May 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Feedback MsQuicBuffers
  • Loading branch information
ManickaP committed Apr 25, 2022
commit f64b1d1eef97ee1833b659c706e5a4aa93657af7
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public void Initialize<T>(IList<T> inputs, Func<T, ReadOnlyMemory<byte>> toBuffe
{
ArrayPool<MemoryHandle>.Shared.Return(_handles);
_handles = ArrayPool<MemoryHandle>.Shared.Rent(inputs.Count);
Array.Clear(_handles);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rented array can be several times longer than what you have asked for, so this will be clearing more than necessary. However, clearing just the right amount will be complicate the reuse logic.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end I opted to use static array pool for MsQuicBuffers and clear the array upon return.

}
if (_count < inputs.Count)
{
Expand All @@ -71,7 +72,7 @@ public void Initialize<T>(IList<T> inputs, Func<T, ReadOnlyMemory<byte>> toBuffe
/// </summary>
public void Reset()
{
for (int i = 0; i < _handles.Length; ++i)
for (int i = 0; i < _count; ++i)
{
_handles[i].Dispose();
}
Expand Down