Handle case to update loop tables when preheader is removed #68803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsFixes: #68756
|
Contributor
Author
|
There are diffs that occurs because we have stopped down scaling the loop blocks in certain cases. |
Member
|
@dotnet/jit-contrib |
Contributor
Author
|
Ping. Can someone review this to unblock the clean libraries-jitstress? |
jakobbotsch
approved these changes
May 10, 2022
Member
jakobbotsch
left a comment
jakobbotsch
left a comment
There was a problem hiding this comment.
This looks fine to me, but am not familiar with the code.
BruceForstall
approved these changes
May 10, 2022
Contributor
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
LGTM.
It feels like this unmarking / unscaling still needs to be made more robust somehow.
Contributor
Author
Opened #68844 to track it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #68756 (comment)
Fixes: #68756