Skip to content

Optimize string.EndsWith(char) for const values #69038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GrabYourPitchforks merged 6 commits into from
May 20, 2022
Merged

Optimize string.EndsWith(char) for const values #69038

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
abf1ab3
Optimize string.EndsWith(char) for const values
GrabYourPitchforks May 8, 2022
6b4edee
Merge remote-tracking branch 'origin/main' into endswith
GrabYourPitchforks May 9, 2022
d5e008f
Cleanup usage of StartsWith/EndsWith throughout libs
GrabYourPitchforks May 9, 2022
b606c97
Fix typo
GrabYourPitchforks May 10, 2022
815bf95
Revert bad UriBuilder change
GrabYourPitchforks May 10, 2022
7cb952e
Apply suggestions from code review
GrabYourPitchforks May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert bad UriBuilder change
  • Loading branch information
@GrabYourPitchforks
GrabYourPitchforks committed May 10, 2022
commit 815bf95d3970e089d73fb58d8ff9602f26504698
10 changes: 5 additions & 5 deletions src/libraries/System.Private.Uri/src/System/UriBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,16 @@ public UriBuilder(string? scheme, string? host, int port, string? pathValue)
public UriBuilder(string? scheme, string? host, int port, string? path, string? extraValue)
: this(scheme, host, port, path)
{
if (extraValue is not null)
if (!string.IsNullOrEmpty(extraValue))
{
if (extraValue.StartsWith('#'))
if (extraValue[0] == '#')
{
_fragment = extraValue;
}
else if (extraValue.StartsWith('?'))
else if (extraValue[0] == '?')
{
int fragmentIndex = extraValue.IndexOf('#');
if (fragmentIndex < 0)
if (fragmentIndex == -1)
{
_query = extraValue;
}
Expand Down Expand Up @@ -163,7 +163,7 @@ public string Host
get => _host;
set
{
if (!string.IsNullOrEmpty(value) && value[0] != '[' && value.Contains(':'))
if (!string.IsNullOrEmpty(value) && value.Contains(':') && value[0] != '[')
{
//probable ipv6 address - Note: this is only supported for cases where the authority is inet-based.
value = "[" + value + "]";
Expand Down